SS4 compatibility #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=============================================
+ Coverage 11.6% 75.72% +64.12%
- Complexity 0 29 +29
=============================================
Files 238 5 -233
Lines 42478 103 -42375
=============================================
- Hits 4929 78 -4851
+ Misses 37549 25 -37524
Continue to review full report at Codecov.
|
Require guzzle Clean up and refactor. Clean code. Be a tidy Dutchy Badges badges badges badges, mushroom mushroom!
|
Why is CodeClimate taking Framework in to account? :| |
zanderwar
suggested changes
Oct 29, 2017
composer.json
Outdated
| } | ||
| }, | ||
| "target-dir": "stripeslack" | ||
| "extra": { | ||
| "installer-name": "stripeslack" |
There was a problem hiding this comment.
You're missing expose here for your image directory
There was a problem hiding this comment.
Yep, good one, should be fixed by now :)
zanderwar
approved these changes
Nov 20, 2017
The recipe is one way of installing the CMS, but not the only way. This change also fixes situations where the silverstripe/recipe-cms ^4 has been installed, rather than ^1 (the numbering of which was a bug)
The action needs to be public.
FIX: Bind to package, not recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unacceptable! Needs squashy!