Add output bundle spec to common module #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuangwang
requested review from
jamesdaniels,
leoortizz and
tonyjhuang
as code owners
Yuangwang
requested review from
sjjj986,
blidd-google and
taeold
as code owners
sjjj986
reviewed
Aug 27, 2024
tonyjhuang
reviewed
Aug 28, 2024
tonyjhuang
requested changes
Sep 3, 2024
| // Environment variable present in the server execution environment. | ||
| environmentVariables?: EnvVarConfig[]; | ||
| // The maximum number of concurrent requests that each server instance can receive. | ||
| // Defaults to 80. |
There was a problem hiding this comment.
What if we link to the product docs instead so we have a single source of truth?
tonyjhuang
reviewed
Sep 3, 2024
| // The amount of memory available for a server instance. | ||
| // Commonly one of: "256" | "512" | "1024" | "2048" | "4096" | "8192" | "16384" | ||
| // Defaults to 512MiB. | ||
| memoryMiB?: string; |
There was a problem hiding this comment.
Good catch, we probably want number here too
tonyjhuang
approved these changes
Sep 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface will be used in the other adapters as the output bundle