Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pnpm build for angular #187

Merged
merged 2 commits into from
May 10, 2024
Merged

Fix pnpm build for angular #187

merged 2 commits into from
May 10, 2024

Conversation

Yuangwang
Copy link
Collaborator

Check one layer up in require.resolve

@Yuangwang Yuangwang marked this pull request as ready for review May 10, 2024 21:40
@Yuangwang Yuangwang requested a review from jamesdaniels as a code owner May 10, 2024 21:40
Copy link
Collaborator

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about reusing the existing constant otherwise LGTM

@@ -32,14 +32,17 @@ export const REQUIRED_BUILDER = "@angular-devkit/build-angular:application";
*/
export async function checkStandaloneBuildConditions(cwd: string): Promise<void> {
// dynamically load Angular so this can be used in an NPX context
const angularCorePath = require.resolve("@angular/core", { paths: [process.cwd()] });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the cwd var?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Yuangwang Yuangwang merged commit e48f2e9 into main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants