Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Next.js image errors #125

Merged
merged 3 commits into from
Dec 7, 2023
Merged

fix Next.js image errors #125

merged 3 commits into from
Dec 7, 2023

Conversation

leoortizz
Copy link
Contributor

@leoortizz leoortizz commented Dec 6, 2023 •
edited
Loading

fixes 500 error "url" parameter is valid but upstream response is invalid in images optimized by Next.js

@leoortizz leoortizz changed the title localhost as Next.js server hostname fix Next.js image errors Dec 6, 2023
jamesdaniels
jamesdaniels approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@jamesdaniels jamesdaniels left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to manually test against older NextJS versions.

@leoortizz leoortizz marked this pull request as ready for review December 7, 2023 15:43
@jamesdaniels jamesdaniels merged commit 671b1f9 into main Dec 7, 2023
9 checks passed
@jamesdaniels jamesdaniels deleted the leoortizz_fix-nextjs-images branch December 7, 2023 15:48
@leoortizz leoortizz mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoortizz @jamesdaniels