Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change test internal libwasmvm binary triggered only build PR #143

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

loloicci
Copy link
Contributor

This PR changes the trigger of the test of internal libwasmvm binaries.
This is always triggered before this PR, and this PR changes it triggered only PR by the libwasmvm build bot.

Description

wasmvm has 2 tests for PR for the main branch, before this PR.

  • Building libwasmvm binaries from the source and doing tests with it
  • Doing tests with libwasmvm included in internal/api directory

An error is caused in CI when internal/api's libwasmvm is old, though we have a CI building libwasmvm binaries after the main branch is updated.
As a result, if PR publishers think that they leave building libwasmvm on CI after the merge, internal libwasmvm's test fails. (now we have this issue on #142)

To solve this, we change the trigger of the test of internal/api's libwasmvm binaries.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci requested review from 170210 and zemyblue and removed request for da1suk8 and Kynea0b February 14, 2024 13:03
@loloicci loloicci self-assigned this Feb 14, 2024
@loloicci loloicci changed the title Update release ci ci: change test internal libwasmvm binary triggered only build PR Feb 14, 2024
Copy link
Contributor

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 7579f34 into Finschia:main Feb 16, 2024
10 checks passed
@loloicci loloicci deleted the update-release-ci branch February 16, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants