Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: use pre-release versioning and set version to 1.1.1-0.11.6 #130

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Oct 18, 2023

Description

The go command cannot recognize the build metadata(+) tag, this causes a problem in wasmd where the version check of libwasmvm cannot be done.

So I reverted to the previous pre-release versioning of wasmvm.

Set version to v1.1.1-0.11.6.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@da1suk8 da1suk8 changed the title revert: set version to 1.1.1-0.11.6 revert: use pre-release versioning and set version to 1.1.1-0.11.6 Oct 18, 2023
@da1suk8 da1suk8 marked this pull request as ready for review October 18, 2023 10:22
@170210 170210 self-requested a review October 18, 2023 10:50
@170210
Copy link
Contributor

170210 commented Oct 18, 2023

Have you tried the libwasmvm.dylib in #129 to test wasmd?

@da1suk8
Copy link
Member Author

da1suk8 commented Oct 18, 2023

It has not even to do with the cause of this problem.
Thanks for the suggestion.

@da1suk8 da1suk8 merged commit 526626d into Finschia:main Oct 18, 2023
10 checks passed
@da1suk8 da1suk8 deleted the revert/pre-release-tag branch October 18, 2023 23:21
@da1suk8 da1suk8 mentioned this pull request Oct 18, 2023
4 tasks
@da1suk8 da1suk8 self-assigned this Oct 19, 2023
@170210 170210 mentioned this pull request Dec 19, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants