Add unique handling of servers #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 65.39% 65.71% +0.32%
==========================================
Files 278 279 +1
Lines 37995 38046 +51
==========================================
+ Hits 24846 25003 +157
+ Misses 11328 11242 -86
+ Partials 1821 1801 -20
|
Kynea0b
added
the
C: enhancement
Kynea0b
suggested changes
Nov 30, 2022
torao
approved these changes
Nov 30, 2022
torao
previously approved these changes
Nov 30, 2022
|
My comments in this PR aren't important things and you can "Resolve Conversation" each of them yourself if it doesn't require any particular fix. |
Kynea0b
previously approved these changes
Nov 30, 2022
Mdaiki0730
requested changes
Nov 30, 2022
Mdaiki0730
previously approved these changes
Nov 30, 2022
tnasu
dismissed stale reviews from Mdaiki0730, Kynea0b, and torao
via
33cd9fd
torao
approved these changes
Dec 1, 2022
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There could be a scenario in which the light client tries to verify the content from the primary by cross-checking with the primary itself. This would lead to less security in the implementation of the light client for the state sync. So eliminating the duplication.