Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply GovMint on x/foundation #110

Merged
merged 4 commits into from
Oct 27, 2022
Merged

feat: apply GovMint on x/foundation #110

merged 4 commits into from
Oct 27, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Oct 27, 2022 •
edited
Loading

Description

Motivation and context

Refer: #102

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@dudong2 dudong2 self-assigned this Oct 27, 2022
@0Tech 0Tech self-requested a review October 27, 2022 10:22
0Tech
0Tech reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the change log.

0Tech
0Tech reviewed Oct 27, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
zemyblue
zemyblue reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the title more understandable?

@dudong2 dudong2 changed the title feat: bump up github.com/line/lbm-sdk 66988a235 feat: apply govmint on x/foundation Oct 27, 2022
@dudong2 dudong2 changed the title feat: apply govmint on x/foundation feat: apply GovMint on x/foundation Oct 27, 2022
zemyblue
zemyblue reviewed Oct 27, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dudong2 dudong2 requested a review from zemyblue October 27, 2022 12:10
@dudong2 dudong2 merged commit c85bc2e into main Oct 27, 2022
@dudong2 dudong2 deleted the dudong2/feat/bump-up-lbm-sdk-66988a235 branch October 27, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0Tech 0Tech 0Tech approved these changes

@zemyblue zemyblue zemyblue approved these changes

@loin3 loin3 Awaiting requested review from loin3

Assignees

@dudong2 dudong2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dudong2 @zemyblue @0Tech