Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor queries of x/collection and x/token #957

Merged
merged 11 commits into from
Apr 13, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Apr 9, 2023

Description

This patch would:

  • revert changes by client's requests (fix: replace query errors on the original modules into gRPC ones #956) which have significant semantic errors.
    • revert all checks relevant to x/auth's state.
    • make Query/Balance not to emit error and just simply return 0.
  • check the existence of the relevant contract in Query/HoldersByOperator.
  • wrap non stateful errors with gRPC InvalidArgument error.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech requested a review from zemyblue April 9, 2023 04:35
@0Tech 0Tech self-assigned this Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #957 (80c52a6) into rc/v0.47.0-alpha1 (88c4242) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           rc/v0.47.0-alpha1     #957      +/-   ##
=====================================================
- Coverage              62.51%   62.50%   -0.01%     
=====================================================
  Files                    655      655              
  Lines                  79939    79921      -18     
=====================================================
- Hits                   49970    49955      -15     
+ Misses                 27286    27284       -2     
+ Partials                2683     2682       -1     
Impacted Files Coverage Δ
simapp/app.go 81.93% <100.00%> (ø)
x/collection/keeper/grpc_query.go 94.96% <100.00%> (+0.48%) ⬆️
x/token/keeper/grpc_query.go 96.49% <100.00%> (-0.18%) ⬇️

@0Tech 0Tech marked this pull request as ready for review April 9, 2023 04:57
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check x/token module case.

@0Tech
Copy link
Collaborator Author

0Tech commented Apr 9, 2023

Please check x/token module case.

I've already checked the x/token Query/Balance and there is nothing to modify. It's good to go.

@0Tech 0Tech marked this pull request as draft April 12, 2023 05:19
@0Tech 0Tech changed the title fix: do not check existence of collection in Query/Balance fix: refactor queries of x/collection and x/token Apr 12, 2023
@0Tech 0Tech marked this pull request as ready for review April 12, 2023 09:27
@0Tech 0Tech merged commit 631ca58 into Finschia:rc/v0.47.0-alpha1 Apr 13, 2023
@0Tech 0Tech deleted the grpc-query-errors branch April 13, 2023 02:11
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Apr 21, 2023
* rc/v0.47.0-alpha1: (34 commits)
  ci: update docker action (Finschia#983)
  fix: revert Finschia#952 (Finschia#984)
  refactor: refactor x/token,collection query errors (Finschia#980)
  fix: not to throw error when no txs in block (Finschia#982)
  chore: change import path to `github.com/Finschia/finschia-sdk` (Finschia#970)
  fix: remove legacy events on x/collection and x/token (Finschia#966)
  chore: provide specific error messages on x/collection queries (Finschia#965)
  fix: check event determinism on original modules (Finschia#963)
  fix: refactor queries of x/collection and x/token (Finschia#957)
  chore: address generation of the empty coins in x/foundation (Finschia#952)
  fix: do not loop enum in x/collection (Finschia#961)
  fix: fix default next class ids of x/collection (Finschia#960)
  fix: revert Finschia#955 and add Query/HasParent into x/collection (Finschia#959)
  fix: replace query errors on the original modules into gRPC ones (Finschia#956)
  fix: return nil where the parent not exists in x/collection Query/Parent (Finschia#955)
  fix: remove duplicated events in x/collection Msg/Modify (Finschia#954)
  fix: allow zero amount of coin in x/collection Query/Balance (Finschia#953)
  fix: unpack proposals in x/foundation import-genesis (Finschia#947)
  fix: fix broken x/foundation invariant on treasury (Finschia#946)
  docs: update comments in the x/token,collection events proto (Finschia#944)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants