Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove some x/token,collection queries on listable collections #881

Merged
merged 6 commits into from
Feb 9, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Feb 6, 2023

Description

Closes: #878

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #881 (8f7f7fd) into main (ec7cd38) will decrease coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   62.45%   62.31%   -0.15%     
==========================================
  Files         653      653              
  Lines       79873    79512     -361     
==========================================
- Hits        49884    49546     -338     
+ Misses      27298    27285      -13     
+ Partials     2691     2681      -10     
Impacted Files Coverage Δ
x/collection/client/testutil/query.go 100.00% <ø> (ø)
x/collection/keeper/grpc_query.go 92.99% <ø> (+3.03%) ⬆️
x/collection/keeper/keys.go 100.00% <ø> (ø)
x/token/client/testutil/query.go 100.00% <ø> (ø)
x/token/keeper/grpc_query.go 95.94% <ø> (+1.36%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️

@0Tech 0Tech marked this pull request as ready for review February 8, 2023 05:18
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit e2aa3ea into Finschia:main Feb 9, 2023
@0Tech 0Tech deleted the remove_query branch February 9, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove recource-intensive query api fo x/collection and x/token
3 participants