Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detach ibc module #858

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Jan 10, 2023

Description

For ease of version management of lbm-sdk and ibc-go, it is necessary to detach the ibc module.
ref. https://github.com/line/ibc-go
closes: #859

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 changed the title feat: remove ibc module feat: detach ibc module Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #858 (849c0de) into main (0fbc2fc) will decrease coverage by 1.19%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   62.77%   61.57%   -1.20%     
==========================================
  Files         812      653     -159     
  Lines       92179    79881   -12298     
==========================================
- Hits        57866    49188    -8678     
+ Misses      31068    27873    -3195     
+ Partials     3245     2820     -425     
Impacted Files Coverage Δ
server/grpc/gogoreflection/fix_registration.go 31.81% <ø> (ø)
simapp/test_access.go 0.00% <ø> (ø)
simapp/app.go 82.30% <100.00%> (-2.74%) ⬇️
x/token/msgs.go 49.42% <0.00%> (-3.05%) ⬇️
codec/amino.go 74.52% <0.00%> (-1.89%) ⬇️
x/ibc/core/23-commitment/types/merkle.go
x/ibc/light-clients/99-ostracon/types/header.go
x/ibc/core/keeper/msg_server.go
x/ibc/core/04-channel/keeper/grpc_query.go
x/ibc/light-clients/06-solomachine/types/proof.go
... and 77 more

@dudong2 dudong2 self-assigned this Jan 10, 2023
@dudong2 dudong2 added the A: improvement Changes in existing functionality label Jan 10, 2023
@dudong2 dudong2 marked this pull request as ready for review January 11, 2023 00:47
@tkxkd0159 tkxkd0159 self-requested a review January 12, 2023 02:22
x/auth/ante/ante_test.go Outdated Show resolved Hide resolved
@dudong2 dudong2 merged commit 8fb9744 into Finschia:main Jan 13, 2023
@dudong2 dudong2 deleted the dudong2/feat/detach-ibc branch January 13, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detach ibc module
3 participants