Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guide users to use generate only in messages for x/foundation authority #773

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 31, 2022

Description

This patch will guide users to use the generate-only flag in following commands:

  • MsgUpdateParams
  • MsgWithdrawFromTreasury
  • MsgUpdateMembers
  • MsgUpdateDecisionPolicy
  • MsgGrant
  • MsgRevoke
  • MsgGovMint

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the C:x/foundation x/foundation module label Oct 31, 2022
@0Tech 0Tech self-assigned this Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (rc9/v0.46.0@0137a62). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             rc9/v0.46.0     #773   +/-   ##
==============================================
  Coverage               ?   62.18%           
==============================================
  Files                  ?      880           
  Lines                  ?    99479           
  Branches               ?        0           
==============================================
  Hits                   ?    61857           
  Misses                 ?    34009           
  Partials               ?     3613           

@0Tech 0Tech marked this pull request as ready for review October 31, 2022 02:37
x/foundation/client/cli/tx.go Outdated Show resolved Hide resolved
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few simple questions because of my poor understanding.

  1. What is the purpose of CLI method with authority? (like when & why use it?)
    In docs mentioned, authority is a module account and have no private key. Then, how could sign this message with CLI? I just guessed those kinds of method only are executed by keeper through Exec.
  2. How do we know the address of module account?

@0Tech
Copy link
Collaborator Author

0Tech commented Oct 31, 2022

1. What is the purpose of CLI method with `authority`? (like when & why use it?)
   In docs mentioned, authority is a module account and have no private key. Then, how could sign this message with CLI? I just guessed those kinds of method only are executed by keeper through `Exec`.

Please refer to the notes:
https://github.com/line/lbm-sdk/blob/v0.46.0-rc9/x/foundation/README.md#transactions

2. How do we know the address of module account?

It's just a truncated (20 bytes) sha256sum of a module name.

@0Tech 0Tech requested a review from tkxkd0159 October 31, 2022 05:51
@tkxkd0159
Copy link
Member

tkxkd0159 commented Oct 31, 2022

Please refer to the notes: https://github.com/line/lbm-sdk/blob/v0.46.0-rc9/x/foundation/README.md#transactions

Is it right that those CLI method just helps users for populating messages field easily?

@0Tech
Copy link
Collaborator Author

0Tech commented Oct 31, 2022

Please refer to the notes: https://github.com/line/lbm-sdk/blob/v0.46.0-rc9/x/foundation/README.md#transactions

Is it right that those CLI method just helps users for populating messages field easily?

Yes, that's it.

@0Tech 0Tech merged commit 7e71801 into Finschia:rc9/v0.46.0 Oct 31, 2022
@0Tech 0Tech deleted the foundation_cli branch October 31, 2022 09:23
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants