Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Catch up with address.go in cosmos-sdk v0.45.1 #587

Closed
wants to merge 93 commits into from

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Jul 11, 2022

Description

This PR enable to catch up with address.go in cosmos-sdk v0.45.1.

closes: #578

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #587 (fccca83) into main (1bc3aac) will decrease coverage by 0.16%.
The diff coverage is 51.45%.

❗ Current head fccca83 differs from pull request most recent head f137bfb. Consider uploading reports for the commit f137bfb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   60.60%   60.43%   -0.17%     
==========================================
  Files         814      814              
  Lines       94798    95261     +463     
==========================================
+ Hits        57448    57575     +127     
- Misses      34097    34339     +242     
- Partials     3253     3347      +94     
Impacted Files Coverage Δ
client/rpc/validators.go 1.53% <0.00%> (ø)
server/config/config.go 41.35% <ø> (-0.44%) ⬇️
server/init.go 0.00% <0.00%> (ø)
simapp/export.go 12.30% <0.00%> (-0.50%) ⬇️
simapp/simd/cmd/root.go 81.81% <ø> (+0.96%) ⬆️
simapp/test_helpers.go 6.72% <0.00%> (+0.02%) ⬆️
x/auth/client/cli/query.go 2.15% <0.00%> (ø)
x/auth/client/cli/validate_sigs.go 0.00% <0.00%> (ø)
x/auth/client/testutil/suite.go 96.50% <0.00%> (+0.08%) ⬆️
x/auth/client/tx.go 36.66% <0.00%> (ø)
... and 205 more

@ulbqb
Copy link
Member Author

ulbqb commented Jul 21, 2022

This PR will be handed over to #603.
The all changes are squashed in the following two commits.

@ulbqb ulbqb closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Effectiveness of Address Format Change and Next Action
6 participants