Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force genOrBroadcastFn even when max-msgs != 0 #364

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: force genOrBroadcastFn even when max-msgs != 0 #364

merged 1 commit into from
Nov 2, 2021

Commits on Nov 1, 2021

  1. fix: force genOrBroadcastFn even when max-msgs != 0 

    If cli tx withdraw-all-rewards sends empty tx, the tx would be
rejected by validators because it has no msgs. However, the cli sends
empty tx only if one sets `--max-msgs=0` which means it does not split
the msgs. When you set `max-msgs` with any positive number, the cli
does not send any tx, which may confuse you because you cannot get the
feedback indicating the address has no delegations.
This patch addresses the problem, by forcing genOrBroadcastFn when the
number of total msgs generated is zero. It will provide the same user
experience with any `max-msgs`.
    @0Tech
    0Tech committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    b899dae View commit details
    Browse the repository at this point in the history