Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify brand name; lfb to lbm #323

Merged
merged 2 commits into from
Sep 10, 2021
Merged

fix: modify brand name; lfb to lbm #323

merged 2 commits into from
Sep 10, 2021

Conversation

egonspace
Copy link

@egonspace egonspace commented Sep 10, 2021

Description

lbm is back!

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Sep 10, 2021
@egonspace egonspace added this to the Ebony alpha milestone Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@84db942). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage        ?   53.16%           
=======================================
  Files           ?      642           
  Lines           ?    47460           
  Branches        ?        0           
=======================================
  Hits            ?    25234           
  Misses          ?    19364           
  Partials        ?     2862           

Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No lfb usage found.
The build worked well.
LGTM.

@egonspace egonspace merged commit a18b7c8 into Finschia:main Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants