Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add A New Message For Storing A Code and Instantiating A Contract With It #149

Closed

Conversation

loloicci
Copy link
Contributor

Description

This adds a new message MsgStoreCodeAndInstantiateContract and its handler. This is for storing a WASM code and instantiate a contract from it in one message (tx).

This is the stargate version of #122

closes: #111


  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
    (tests for CLI/REST are not included. The former will be added after adding linkwasmd for stargate, the latter will be added if we need REST.)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/) (There are no docs)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md (It will be generated with script)
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@loloicci loloicci requested review from brew0722, whylee259 and shiki-tak and removed request for brew0722 April 26, 2021 09:43
@loloicci loloicci self-assigned this Apr 26, 2021
@brew0722
Copy link
Contributor

brew0722 commented Apr 27, 2021

FYI, In order to running github actions(lbm-sdk/v2), you should push the branch to origin repository instead of personal repository.
In case of our team, we are using PR branch name like loloicci/v2/feat/xxx.

#127 (comment)

@loloicci
Copy link
Contributor Author

moved to #154. thank you, @brew0722

@loloicci loloicci closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a wasm msg that does both deployment and instantiation
2 participants