feat: add new query to get a swap #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
- Coverage 69.58% 69.57% -0.01%
==========================================
Files 668 668
Lines 56208 56231 +23
==========================================
+ Hits 39111 39125 +14
- Misses 14830 14835 +5
- Partials 2267 2271 +4
|
170210
reviewed
May 17, 2024
0Tech
reviewed
May 20, 2024
0Tech
previously approved these changes
May 20, 2024
zemyblue
reviewed
May 21, 2024
Thanks for finding missing cli. I've just added. |
zemyblue
approved these changes
May 21, 2024
0Tech
approved these changes
May 21, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
* feat: add new query to get a swap * chore: update changelog * fix: add missing pagination param in cli client * chore: lint fix * chore: add grpc-query test * chore: add descriptive message for invalid QuerySwapRequest * chore: add CLI to query swap (cherry picked from commit 92ad675) # Conflicts: # client/docs/swagger-ui/swagger.yaml
5 tasks
jaeseung-bae
added a commit
that referenced
this pull request
May 21, 2024
* feat: add new query to get a swap (#1387) * feat: add new query to get a swap * chore: update changelog * fix: add missing pagination param in cli client * chore: lint fix * chore: add grpc-query test * chore: add descriptive message for invalid QuerySwapRequest * chore: add CLI to query swap (cherry picked from commit 92ad675) # Conflicts: # client/docs/swagger-ui/swagger.yaml * chore: fix conflict --------- Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
client/docs/config.jsonQuerySwapsRequestCLIMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml