feat: save sequence for every bridge request #1351

tkxkd0159 · 2024-05-03T09:30:13Z

Description

closes: #XXXX

We decided to save sequence for every bridge request to help relayers when they retrieve bridge events

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

codecov · 2024-05-03T09:39:28Z

Codecov Report

Attention: Patch coverage is 23.80952% with 32 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (pjdp1@7b421db). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff            @@
##             pjdp1    #1351   +/-   ##
========================================
  Coverage         ?   70.21%           
========================================
  Files            ?      662           
  Lines            ?    55161           
  Branches         ?        0           
========================================
  Hits             ?    38730           
  Misses           ?    14239           
  Partials         ?     2192

Files	Coverage Δ
x/fbridge/keeper/transfer.go	`74.54% <83.33%> (ø)`
x/fbridge/keeper/genesis.go	`0.00% <0.00%> (ø)`
x/fbridge/keeper/grpc_query.go	`0.00% <0.00%> (ø)`

proto/lbm/fbridge/v1/query.proto

* feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct dependencies Signed-off-by: 170210 <j170210@icloud.com> * chore: remove unuse files Signed-off-by: 170210 <j170210@icloud.com> * feat: add proto files Signed-off-by: 170210 <j170210@icloud.com> * chore: make proto-gen Signed-off-by: 170210 <j170210@icloud.com> * chore: fix compile error Signed-off-by: 170210 <j170210@icloud.com> * chore: add new field in params proto Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * docs: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * docs: fix error docs Signed-off-by: 170210 <j170210@icloud.com> * fix: fix consensusversion Signed-off-by: 170210 <j170210@icloud.com> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <j170210@icloud.com> * fix: update proto files Signed-off-by: 170210 <j170210@icloud.com> * fix: fix NewKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <j170210@icloud.com> * chore: use mockgen Signed-off-by: 170210 <j170210@icloud.com> * chore: add tests Signed-off-by: 170210 <j170210@icloud.com> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for test errors Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix appmodulebasic Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: use configuration instead of params Signed-off-by: 170210 <j170210@icloud.com> * chore: refactor new&default fswapped Signed-off-by: 170210 <j170210@icloud.com> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix module_simulation Signed-off-by: 170210 <j170210@icloud.com> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <j170210@icloud.com> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: use io/collection to generate key Signed-off-by: 170210 <j170210@icloud.com> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: remote unnecessary codes Signed-off-by: 170210 <j170210@icloud.com> * fix: add validate for swappable new coin Signed-off-by: 170210 <j170210@icloud.com> * fix: add randomizedGenState Signed-off-by: 170210 <j170210@icloud.com> * fix: fix error doc Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: change proto message fields' name Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <j170210@icloud.com> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <j170210@icloud.com> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <j170210@icloud.com> * chore: fix simulation Signed-off-by: 170210 <j170210@icloud.com> * chore: correct query cli Signed-off-by: 170210 <j170210@icloud.com> * chore: add query for test Signed-off-by: 170210 <j170210@icloud.com> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: 170210 <85928898+170210@users.noreply.github.com> Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>

* feat: initialize fswap module (Finschia#1336) * feat: initial fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct dependencies Signed-off-by: 170210 <j170210@icloud.com> * chore: remove unuse files Signed-off-by: 170210 <j170210@icloud.com> * feat: add proto files Signed-off-by: 170210 <j170210@icloud.com> * chore: make proto-gen Signed-off-by: 170210 <j170210@icloud.com> * chore: fix compile error Signed-off-by: 170210 <j170210@icloud.com> * chore: add new field in params proto Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * docs: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * docs: fix error docs Signed-off-by: 170210 <j170210@icloud.com> * fix: fix consensusversion Signed-off-by: 170210 <j170210@icloud.com> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <j170210@icloud.com> * fix: update proto files Signed-off-by: 170210 <j170210@icloud.com> * fix: fix NewKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> * feat: implement fswap module's genesis and params (Finschia#1339) * feat: implement genesis related functions Signed-off-by: 170210 <j170210@icloud.com> * chore: use mockgen Signed-off-by: 170210 <j170210@icloud.com> * chore: add tests Signed-off-by: 170210 <j170210@icloud.com> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for test errors Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix appmodulebasic Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: use configuration instead of params Signed-off-by: 170210 <j170210@icloud.com> * chore: refactor new&default fswapped Signed-off-by: 170210 <j170210@icloud.com> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix module_simulation Signed-off-by: 170210 <j170210@icloud.com> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <j170210@icloud.com> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: use io/collection to generate key Signed-off-by: 170210 <j170210@icloud.com> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: remote unnecessary codes Signed-off-by: 170210 <j170210@icloud.com> * fix: add validate for swappable new coin Signed-off-by: 170210 <j170210@icloud.com> * fix: add randomizedGenState Signed-off-by: 170210 <j170210@icloud.com> * fix: fix error doc Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: change proto message fields' name Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> * feat: initialize fbridge module (Finschia#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (Finschia#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (Finschia#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345) * refactor: fswap module's proto Signed-off-by: 170210 <j170210@icloud.com> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <j170210@icloud.com> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <j170210@icloud.com> * chore: fix simulation Signed-off-by: 170210 <j170210@icloud.com> * chore: correct query cli Signed-off-by: 170210 <j170210@icloud.com> * chore: add query for test Signed-off-by: 170210 <j170210@icloud.com> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: 170210 <85928898+170210@users.noreply.github.com> Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>

* feat: introduce new modules(fswap, fbridge) (#1352) * feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <j170210@icloud.com> * chore: correct dependencies Signed-off-by: 170210 <j170210@icloud.com> * chore: remove unuse files Signed-off-by: 170210 <j170210@icloud.com> * feat: add proto files Signed-off-by: 170210 <j170210@icloud.com> * chore: make proto-gen Signed-off-by: 170210 <j170210@icloud.com> * chore: fix compile error Signed-off-by: 170210 <j170210@icloud.com> * chore: add new field in params proto Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> * docs: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * docs: fix error docs Signed-off-by: 170210 <j170210@icloud.com> * fix: fix consensusversion Signed-off-by: 170210 <j170210@icloud.com> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <j170210@icloud.com> * fix: update proto files Signed-off-by: 170210 <j170210@icloud.com> * fix: fix NewKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for comment Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <j170210@icloud.com> * chore: use mockgen Signed-off-by: 170210 <j170210@icloud.com> * chore: add tests Signed-off-by: 170210 <j170210@icloud.com> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix for test errors Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix appmodulebasic Signed-off-by: 170210 <j170210@icloud.com> * chore: update CHANGLOG.md Signed-off-by: 170210 <j170210@icloud.com> * fix: use configuration instead of params Signed-off-by: 170210 <j170210@icloud.com> * chore: refactor new&default fswapped Signed-off-by: 170210 <j170210@icloud.com> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: fix module_simulation Signed-off-by: 170210 <j170210@icloud.com> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <j170210@icloud.com> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: use io/collection to generate key Signed-off-by: 170210 <j170210@icloud.com> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: remote unnecessary codes Signed-off-by: 170210 <j170210@icloud.com> * fix: add validate for swappable new coin Signed-off-by: 170210 <j170210@icloud.com> * fix: add randomizedGenState Signed-off-by: 170210 <j170210@icloud.com> * fix: fix error doc Signed-off-by: 170210 <j170210@icloud.com> * fix: fix lint Signed-off-by: 170210 <j170210@icloud.com> * fix: change proto message fields' name Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <j170210@icloud.com> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <j170210@icloud.com> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <j170210@icloud.com> * chore: fix simulation Signed-off-by: 170210 <j170210@icloud.com> * chore: correct query cli Signed-off-by: 170210 <j170210@icloud.com> * chore: add query for test Signed-off-by: 170210 <j170210@icloud.com> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com> --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: 170210 <85928898+170210@users.noreply.github.com> Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com> * chore: lint fix --------- Signed-off-by: 170210 <j170210@icloud.com> Co-authored-by: 170210 <85928898+170210@users.noreply.github.com> Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>

feat: add SeqToBlocknum

b000743

tkxkd0159 changed the title ~~feat: add SeqToBlocknum~~ feat: save sequence for every bridge request May 3, 2024

lint

ae94c6c

tkxkd0159 changed the title ~~feat: save sequence for every bridge request~~ feat: saving sequence for every bridge request May 3, 2024

tkxkd0159 changed the title ~~feat: saving sequence for every bridge request~~ feat: save sequence for every bridge request May 3, 2024

add CHANGELOG

530603a

tkxkd0159 marked this pull request as ready for review May 3, 2024 09:39

tkxkd0159 requested review from zemyblue, 0Tech and jaeseung-bae as code owners May 3, 2024 09:39

tkxkd0159 self-assigned this May 3, 2024

tkxkd0159 added the A: feature New features label May 3, 2024

0Tech reviewed May 3, 2024

View reviewed changes

proto/lbm/fbridge/v1/query.proto Show resolved Hide resolved

tkxkd0159 requested a review from 0Tech May 3, 2024 11:11

add query bound for SeqToBlocknums

384dbce

tkxkd0159 force-pushed the seqtonum branch from 131409c to 384dbce Compare May 3, 2024 11:12

chore

5cc8070

0Tech approved these changes May 3, 2024

View reviewed changes

zemyblue approved these changes May 3, 2024

View reviewed changes

tkxkd0159 merged commit 8d79d25 into pjdp1 May 3, 2024
33 checks passed

tkxkd0159 deleted the seqtonum branch May 3, 2024 11:26

zemyblue mentioned this pull request May 27, 2024

Release finschia-sdk v0.49.0 #1404

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: save sequence for every bridge request #1351

feat: save sequence for every bridge request #1351

tkxkd0159 commented May 3, 2024 •

edited

Loading

codecov bot commented May 3, 2024 •

edited

Loading

feat: save sequence for every bridge request #1351

feat: save sequence for every bridge request #1351

Conversation

tkxkd0159 commented May 3, 2024 • edited Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov bot commented May 3, 2024 • edited Loading

Codecov Report

tkxkd0159 commented May 3, 2024 •

edited

Loading

codecov bot commented May 3, 2024 •

edited

Loading