Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove map iteration non-determinism with keys (backport #1302) #1305

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 26, 2024

Description

closes: #XXXX

ref. cosmos/cosmos-sdk#13377

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1302 done by [Mergify](https://mergify.com).

* remove map iteration non-determinism with keys

* add CHANGELOG

(cherry picked from commit c462f36)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from tkxkd0159 as a code owner March 26, 2024 08:35
@mergify mergify bot added the conflicts label Mar 26, 2024
@mergify mergify bot requested review from zemyblue and 0Tech as code owners March 26, 2024 08:35
Copy link
Contributor Author

mergify bot commented Mar 26, 2024

Cherry-pick of c462f36 has failed:

On branch mergify/bp/release/v0.48.x/pr-1302
Your branch is up to date with 'origin/release/v0.48.x'.

You are currently cherry-picking commit c462f3686.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   baseapp/baseapp.go
	modified:   store/rootmulti/store.go
	modified:   types/module/module.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from jaeseung-bae as a code owner March 26, 2024 08:35
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (1f8e902) to head (b384d08).
Report is 1 commits behind head on release/v0.48.x.

❗ Current head b384d08 differs from pull request most recent head b53b745. Consider uploading reports for the commit b53b745 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.48.x    #1305   +/-   ##
================================================
  Coverage            69.78%   69.78%           
================================================
  Files                  646      646           
  Lines                67507    67526   +19     
================================================
+ Hits                 47109    47126   +17     
- Misses               18212    18214    +2     
  Partials              2186     2186           
Files Coverage Δ
baseapp/baseapp.go 79.35% <100.00%> (+0.13%) ⬆️
store/rootmulti/store.go 75.14% <100.00%> (+0.50%) ⬆️
types/module/module.go 67.21% <66.66%> (-0.15%) ⬇️

... and 1 file with indirect coverage changes

CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech self-requested a review March 29, 2024 02:05
@0Tech 0Tech self-assigned this Mar 29, 2024
@0Tech 0Tech added A: bug Something isn't working C:baseapp C:store and removed conflicts labels Mar 29, 2024
@0Tech 0Tech merged commit 8e8a284 into release/v0.48.x Mar 29, 2024
41 checks passed
@0Tech 0Tech deleted the mergify/bp/release/v0.48.x/pr-1302 branch March 29, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:baseapp C:store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants