feat!: remove x/params usage from x/foundation

.github/workflows/proto.yml

@@ -16,6 +16,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: bufbuild/buf-setup-action@v1.21.0
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
       - uses: bufbuild/buf-lint-action@v1
         with:
           input: "proto"
@@ -25,6 +27,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: bufbuild/buf-setup-action@v1.21.0
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
       - uses: bufbuild/buf-breaking-action@v1
         with:
           input: "proto"

.github/workflows/test.yml

@@ -278,7 +278,7 @@ jobs:
           cd simapp
           go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock rocksdb_build' ./...
       - name: sonarcloud
-        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
+        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft }}
         uses: SonarSource/sonarcloud-github-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -316,7 +316,7 @@ jobs:
           cd x/foundation
           go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock rocksdb_build' ./...
       - name: sonarcloud
-        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
+        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft }}
         uses: SonarSource/sonarcloud-github-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.golangci.yml

@@ -52,8 +52,7 @@ issues:
     - text: "SA1019: codec.NewAminoCodec is deprecated" # TODO remove once migration path is set out
       linters:
         - staticcheck
-    - path: "client/cli"  # TODO(@0Tech): remove after foundation exec proposal removed
-      text: "SA1019: govcli.FlagDescription is deprecated"
+    - text: "SA1019: govcli.FlagDescription is deprecated" # TODO(@0Tech): remove after foundation exec proposal removed
       linters:
         - staticcheck
     - text: "leading space"

CHANGELOG.md

@@ -43,6 +43,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (x/foundation) [\#1198](https://github.com/Finschia/finschia-sdk/pull/1198) update x/foundation to use Finschia/cosmos-sdk
 * (all) [\#1205](https://github.com/Finschia/finschia-sdk/pull/1205) delegate native logics to Finschia/cosmos-sdk
 * (consensus) [\#1178](https://github.com/Finschia/finschia-sdk/pull/1178) change the consensus from Ostracon to Tendermint v0.34.24
+* (x/foundation) [\#1234](https://github.com/Finschia/finschia-sdk/pull/1234) remove x/params usage from x/foundation
 
 ### Improvements
 * (docs) [\#1120](https://github.com/Finschia/finschia-sdk/pull/1120) Update links in x/foundation README.md

proto/lbm/foundation/v1/event.proto

@@ -11,6 +11,11 @@ import "cosmos_proto/cosmos.proto";
 import "cosmos/base/v1beta1/coin.proto";
 import "lbm/foundation/v1/foundation.proto";
 
+// EventUpdateParams is emitted after updating foundation parameters.
+message EventUpdateParams {
+  Params params = 1 [(gogoproto.nullable) = false];
+}
+
 // EventFundTreasury is an event emitted when one funds the treasury.
 message EventFundTreasury {
   string   from                            = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];

proto/lbm/foundation/v1/tx.proto

@@ -19,6 +19,10 @@ option (gogoproto.goproto_getters_all) = false;
 service Msg {
   option (cosmos.msg.v1.service) = true;
 
+  // UpdateParams defines an operation for updating the x/foundation module
+  // parameters.
+  rpc UpdateParams(MsgUpdateParams) returns (MsgUpdateParamsResponse);
+
   // FundTreasury defines a method to fund the treasury.
   rpc FundTreasury(MsgFundTreasury) returns (MsgFundTreasuryResponse);
 
@@ -59,6 +63,24 @@ service Msg {
   rpc Revoke(MsgRevoke) returns (MsgRevokeResponse);
 }
 
+// MsgUpdateParams is the Msg/UpdateParams request type.
+// NOTE: This is not for tx
+message MsgUpdateParams {
+  option (cosmos.msg.v1.signer) = "authority";
+  option (amino.name)           = "lbm-sdk/MsgUpdateParams";
+
+  // authority is the address of the privileged account.
+  string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
+
+  // params defines the x/foundation parameters to update.
+  //
+  // NOTE: All parameters must be supplied.
+  Params params = 2 [(gogoproto.nullable) = false];
+}
+
+// MsgUpdateParamsResponse is the Msg/UpdateParams response type.
+message MsgUpdateParamsResponse {}
+
 // MsgFundTreasury is the Msg/FundTreasury request type.
 message MsgFundTreasury {
   option (cosmos.msg.v1.signer) = "from";
@@ -87,24 +109,6 @@ message MsgWithdrawFromTreasury {
 // MsgWithdrawFromTreasuryResponse is the Msg/WithdrawFromTreasury response type.
 message MsgWithdrawFromTreasuryResponse {}
 
-// MsgUpdateParams is the Msg/UpdateParams request type.
-// NOTE: This is not for tx
-message MsgUpdateParams {
-  option (cosmos.msg.v1.signer) = "authority";
-  option (amino.name)           = "lbm-sdk/MsgUpdateParams";
-
-  // authority is the address of the privileged account.
-  string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
-
-  // params defines the x/foundation parameters to update.
-  //
-  // NOTE: All parameters must be supplied.
-  Params params = 2 [(gogoproto.nullable) = false];
-}
-
-// MsgUpdateParamsResponse is the Msg/UpdateParams response type.
-message MsgUpdateParamsResponse {}
-
 // MsgUpdateMembers is the Msg/UpdateMembers request type.
 // NOTE: This is not for tx
 message MsgUpdateMembers {

scripts/go-lint-all.bash

@@ -31,7 +31,7 @@ else
   for f in $(dirname $(echo "$GIT_DIFF" | tr -d "'") | uniq); do
     echo "linting $f [$(date -Iseconds -u)]" &&
     cd $f &&
-    golangci-lint run ./... -c "${REPO_ROOT}/.golangci.yml" "$@" &&
+    golangci-lint run ./... -c "${REPO_ROOT}/.golangci.yml" "$@"
     cd $REPO_ROOT
   done
-fi
+fi

sonar-project.properties

@@ -1,7 +1,7 @@
-sonar.projectKey=cosmos_cosmos-sdk
-sonar.organization=cosmos
+sonar.projectKey=Finschia_finschia-sdk
+sonar.organization=finschia
 
-sonar.projectName=Cosmos SDK
+sonar.projectName=Finschia SDK
 sonar.project.monorepo.enabled=true
 
 sonar.sources=.
@@ -17,4 +17,4 @@ sonar.scm.provider=git
 # Exclude C/C++/Objective-C files from analysis
 sonar.c.file.suffixes=-
 sonar.cpp.file.suffixes=-
-sonar.objc.file.suffixes=-
+sonar.objc.file.suffixes=-

tests/e2e/foundation/tx.go

@@ -15,6 +15,52 @@ import (
 	"github.com/Finschia/finschia-sdk/x/foundation/client/cli"
 )
 
+func (s *E2ETestSuite) TestNewTxCmdUpdateParams() {
+	val := s.network.Validators[0]
+
+	commonArgs := []string{
+		fmt.Sprintf("--%s", flags.FlagGenerateOnly),
+	}
+
+	testCases := map[string]struct {
+		args  []string
+		valid bool
+	}{
+		"valid transaction": {
+			[]string{
+				s.bytesToString(s.authority),
+				fmt.Sprintf(`{"foundation_tax": "%s"}`, math.LegacyZeroDec()),
+			},
+			true,
+		},
+		"wrong number of args": {
+			[]string{
+				s.bytesToString(s.authority),
+				fmt.Sprintf(`{"foundation_tax": "%s"}`, math.LegacyZeroDec()),
+				"extra",
+			},
+			false,
+		},
+	}
+
+	for name, tc := range testCases {
+		tc := tc
+
+		s.Run(name, func() {
+			cmd := cli.NewTxCmdUpdateParams()
+			out, err := clitestutil.ExecTestCLICmd(val.ClientCtx, cmd, append(tc.args, commonArgs...))
+			if !tc.valid {
+				s.Require().Error(err)
+				return
+			}
+			s.Require().NoError(err)
+
+			var res txtypes.Tx
+			s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(out.Bytes(), &res), out)
+		})
+	}
+}
+
 func (s *E2ETestSuite) TestNewTxCmdFundTreasury() {
 	val := s.network.Validators[0]
 	commonArgs := []string{

x/foundation/README.md

@@ -14,9 +14,9 @@ back these foundation-specific functionalities.
 ## Contents
 
 * [Concepts](#concepts)
-* [Parameters](#parameters)
 * [State](#state)
 * [Msg Service](#msg-service)
+    * [Msg/UpdateParams](#msgupdateparams)
     * [Msg/UpdateDecisionPolicy](#msgupdatedecisionpolicy)
     * [Msg/UpdateMembers](#msgupdatemembers)
     * [Msg/LeaveFoundation](#msgleavefoundation)
@@ -30,6 +30,7 @@ back these foundation-specific functionalities.
     * [Msg/FundTreasury](#msgfundtreasury)
     * [Msg/WithdrawFromTreasury](#msgwithdrawfromtreasury)
 * [Events](#events)
+    * [EventUpdateFoundationParams](#eventupdatefoundationparams)
     * [EventUpdateDecisionPolicy](#eventupdatedecisionpolicy)
     * [EventUpdateMembers](#eventupdatedmembers)
     * [EventLeaveFoundation](#eventleavefoundation)
@@ -266,15 +267,16 @@ The foundation can withdraw coins from the treasury. The recipient must have
 the corresponding authorization (`ReceiveFromTreasuryAuthorization`) prior to
 sending the message `Msg/WithdrawFromTreasury`.
 
-# Parameters
 
-## FoundationTax
+# State
 
-The value of `FoundationTax` is the foundation tax rate.
+## Params
 
-* FoundationTax: `sdk.Dec`
+### FoundationTax
 
-# State
+* Params: `0x00 -> PropocolBuffer(Params)`.
+
+The value of `FoundationTax` is the foundation tax rate.
 
 ## FoundationInfo
 
@@ -343,6 +345,17 @@ Authorization) tuple.
 
 # Msg Service
 
+## Msg/UpdateParams
+
+The `MsgUpdateParams` can be used to update the parameters of `foundation`.
+
++++ https://github.com/Finschia/finschia-sdk/blob/f682f758268c19dd93958abbbaf697f51e6991b3/proto/lbm/foundation/v1/tx.proto#L62-L71
+
+It's expected to fail if:
+
+* the authority is not the module's authority.
+* the parameters introduces any new foundation-specific features.
+
 ## Msg/UpdateDecisionPolicy
 
 The `MsgUpdateDecisionPolicy` can be used to update the decision policy.
@@ -508,6 +521,15 @@ The message handling should fail if:
 
 # Events
 
+## EventUpdateFoundationParams
+
+`EventUpdateFoundationParams` is an event emitted when the foundation
+parameters have been updated.
+
+| Attribute Key | Attribute Value |
+|---------------|-----------------|
+| params        | {params}        |
+
 ## EventUpdateDecisionPolicy
 
 `EventUpdateDecisionPolicy` is an event emitted when the decision policy have
@@ -983,6 +1005,25 @@ simd tx foundation --help
 you cannot broadcast the message directly. The use of those commands is to make
 it easier to generate the messages by end users.
 
+#### update-params
+
+The `update-params` command allows users to update the foundation's parameters.
+
+```bash
+simd tx foundation update-params [authority] [params-json] [flags]
+```
+
+Example:
+
+```bash
+simd tx foundation update-params link1... \
+    '{
+       "foundation_tax": "0.1"
+     }'
+```
+
+**Note:** The signer MUST be the module's authority.
+
 #### update-members
 
 The `update-members` command allows users to update the foundation's members.

x/foundation/client/cli/tx.go

@@ -36,6 +36,15 @@ func validateGenerateOnly(cmd *cobra.Command) error {
 	return nil
 }
 
+func parseParams(codec codec.Codec, paramsJSON string) (*foundation.Params, error) {
+	var params foundation.Params
+	if err := codec.UnmarshalJSON([]byte(paramsJSON), &params); err != nil {
+		return nil, err
+	}
+
+	return &params, nil
+}
+
 func parseMemberRequests(codec codec.Codec, membersJSON string) ([]foundation.MemberRequest, error) {
 	var cliMembers []json.RawMessage
 	if err := json.Unmarshal([]byte(membersJSON), &cliMembers); err != nil {
@@ -158,6 +167,7 @@ func NewTxCmd() *cobra.Command {
 	}
 
 	txCmd.AddCommand(
+		NewTxCmdUpdateParams(),
 		NewTxCmdFundTreasury(),
 		NewTxCmdWithdrawFromTreasury(),
 		NewTxCmdUpdateMembers(),
@@ -174,6 +184,44 @@ func NewTxCmd() *cobra.Command {
 	return txCmd
 }
 
+func NewTxCmdUpdateParams() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "update-params [authority] [params-json]",
+		Args:  cobra.ExactArgs(2),
+		Short: "Update params",
+		Long: `Update x/foundation parameters.
+Example of the content of params-json:
+{
+  "foundation_tax": "0.1"
+}
+`,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			if err := validateGenerateOnly(cmd); err != nil {
+				return err
+			}
+
+			clientCtx, err := client.GetClientTxContext(cmd)
+			if err != nil {
+				return err
+			}
+
+			params, err := parseParams(clientCtx.Codec, args[1])
+			if err != nil {
+				return err
+			}
+
+			msg := foundation.MsgUpdateParams{
+				Authority: args[0],
+				Params:    *params,
+			}
+			return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), &msg)
+		},
+	}
+
+	flags.AddTxFlagsToCmd(cmd)
+	return cmd
+}
+
 func NewTxCmdFundTreasury() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "fund-treasury [from] [amount]",