fix: fix redundant priv-validator-key generation when running with kms

[jaeseung-bae]

Description

• Fix for redundant key generation. With running kms, generating priv-key is unnecessary.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

• I followed the contributing guidelines and code of conduct.
• I have added a relevant changelog to CHANGELOG.md
• I have added tests to cover my changes.
• I have updated the documentation accordingly.
• I have updated API documentation client/docs/swagger-ui/swagger.yaml

[codecov]

Codecov Report

Merging #1086 (7a004cc) into rc/v0.48.0-rcx (0538b80) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1086   +/-   ##
===============================================
  Coverage           69.70%   69.70%           
===============================================
  Files                 642      642           
  Lines               67285    67285           
===============================================
  Hits                46900    46900           
  Misses              18203    18203           
  Partials             2182     2182           

[zemyblue]

I think it's nice to add some explanation about doesn't generate a private key if some condition.

[jaeseung-bae]

I think it's nice to add some explanation about doesn't generate a private key if some condition.

I named the function genPvFileOnlyWhenKmsAddressEmpty to express conditional generation of the key.
The name doesn't seem to be enough.
Do you have any idea?

[zemyblue]

I think it's nice to add some explanation about doesn't generate a private key if some condition.

I named the function genPvFileOnlyWhenKmsAddressEmpty to express conditional generation of the key. The name doesn't seem to be enough. Do you have any idea?

I think the condition of which does not generate a private key seems that the config.yml set priv_validator_laddr is empty string and there is no private key. Is it right?

If then, how about adding this explanation in config.yml. Oh, it is Ostracon's area. right?

[jaeseung-bae]

I think it's nice to add some explanation about doesn't generate a private key if some condition.

I named the function genPvFileOnlyWhenKmsAddressEmpty to express conditional generation of the key. The name doesn't seem to be enough. Do you have any idea?

I think the condition of which does not generate a private key seems that the config.yml set priv_validator_laddr is empty string and there is no private key. Is it right?

If then, how about adding this explanation in config.yml. Oh, it is Ostracon's area. right?

If priv_validator_laddr is empty string, key will be generated. It doesn't check the existence of the key file.
It's nice to put an explanation to config.yml.
Yes, It's ostracon's area. I'll put it in ostracon's area.