Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom r/w gRPC options #1017

Merged
merged 3 commits into from
May 27, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 25, 2023

Description

closes: #1016

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue changed the title Feat/support custom grpc options Feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889) May 25, 2023
@zemyblue zemyblue changed the title Feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889) feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889) May 25, 2023
@zemyblue zemyblue self-assigned this May 25, 2023
@zemyblue zemyblue changed the title feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889) feat: support custom r/w gRPC options May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1017 (b13d221) into main (97b255e) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   62.04%   62.04%           
=======================================
  Files         655      655           
  Lines       78941    78960   +19     
=======================================
+ Hits        48975    48987   +12     
- Misses      27284    27289    +5     
- Partials     2682     2684    +2     
Impacted Files Coverage Δ
server/config/toml.go 20.00% <ø> (ø)
server/config/config.go 43.42% <50.00%> (+0.17%) ⬆️
server/grpc/server.go 63.04% <71.42%> (-1.48%) ⬇️
testutil/network/util.go 70.86% <100.00%> (ø)

... and 1 file with indirect coverage changes

@zemyblue zemyblue added the A: bug Something isn't working label May 25, 2023
@zemyblue zemyblue merged commit 13ae1f6 into Finschia:main May 27, 2023
@zemyblue zemyblue deleted the feat/support_custom_grpc_options branch May 27, 2023 04:01
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request May 27, 2023
* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889)

* chore: add simple unittest for app config

* chore: update changelog

(cherry picked from commit 13ae1f6)
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request May 27, 2023
zemyblue added a commit that referenced this pull request May 30, 2023
* feat: support custom r/w gRPC options (backport #1017)

* chore: update changelog
zemyblue added a commit that referenced this pull request May 30, 2023
* feat: support custom r/w gRPC options (#1017)

* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889)

* chore: add simple unittest for app config

* chore: update changelog

(cherry picked from commit 13ae1f6)

* chore: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A response error occurs when the size of the response exceeds 4MB
3 participants