-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable circleci for extension package #6
Conversation
If there are some based files of the config of circleCI, contracts, ext, etc..., could you write the information on it? |
The original file does not exist, and I deleted unnecessary files from cosmwasm-template and prepared them as ext and contract. |
_deps: &Extern<S, A, Q>, | ||
_contract_id: String, | ||
) -> StdResult<Binary> { | ||
unimplemented!() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a plan to implement? Is it able?
If not, can we develop a contract with no query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will provide a complete token-tester including the query in issue #3 .
&schema_for!(LinkMsgWrapper<CollectionRoute, CollectionMsg>), | ||
&out_dir, | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed? What is this file for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is for generating a json schema that will serve as a guide for the contract developer.
This file is used to generate a json file from the cargo schema
.
I think token-tester needs a README to tell how to compile them. (at least, including the recommended version of rust-optimizer) |
Ok, I'll add the README in issue #3. |
.circleci/config.yml
Outdated
command: rustc --version; cargo --version; rustup --version; rustup target list --installed | ||
- restore_cache: | ||
keys: | ||
- cargocache-v2-package_std-rust:1.44.1-{{ checksum "Cargo.lock" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be nice if making the cache key different from package_std
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
.circleci/config.yml
Outdated
command: rustc --version; cargo --version; rustup --version | ||
- restore_cache: | ||
keys: | ||
- cargocache-v2-contract_burner-rust:1.44.1-{{ checksum "Cargo.lock" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice making the key name related to the job name.
(contract_burner -> contract_token_tester)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
contracts/token-tester/Cargo.toml
Outdated
crate-type = ["cdylib", "rlib"] | ||
|
||
[features] | ||
default = ["cranelift"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to use cranelift
as default?
(I think only the singlepass
is fully implemented currently)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. fixed!
* feat: enable circleci * fix: apply review
Closes: #2
Description
The purpose of this PR is to set up circle CI for newly added ext and contract, so I prepared implementation of minimum to see if the circle CI works properly.
Motivation and context
How has this been tested?
Checklist: