feat: enable circleci for extension package #6
Conversation
|
If there are some based files of the config of circleCI, contracts, ext, etc..., could you write the information on it? |
The original file does not exist, and I deleted unnecessary files from cosmwasm-template and prepared them as ext and contract. |
| _deps: &Extern<S, A, Q>, | ||
| _contract_id: String, | ||
| ) -> StdResult<Binary> { | ||
| unimplemented!() |
There was a problem hiding this comment.
Do you have a plan to implement? Is it able?
If not, can we develop a contract with no query?
There was a problem hiding this comment.
I will provide a complete token-tester including the query in issue #3 .
| &schema_for!(LinkMsgWrapper<CollectionRoute, CollectionMsg>), | ||
| &out_dir, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Is this file needed? What is this file for?
There was a problem hiding this comment.
This file is for generating a json schema that will serve as a guide for the contract developer.
This file is used to generate a json file from the cargo schema.
|
I think token-tester needs a README to tell how to compile them. (at least, including the recommended version of rust-optimizer) |
Ok, I'll add the README in issue #3. |
.circleci/config.yml
Outdated
| command: rustc --version; cargo --version; rustup --version; rustup target list --installed | ||
| - restore_cache: | ||
| keys: | ||
| - cargocache-v2-package_std-rust:1.44.1-{{ checksum "Cargo.lock" }} |
There was a problem hiding this comment.
It seems to be nice if making the cache key different from package_std.
.circleci/config.yml
Outdated
| command: rustc --version; cargo --version; rustup --version | ||
| - restore_cache: | ||
| keys: | ||
| - cargocache-v2-contract_burner-rust:1.44.1-{{ checksum "Cargo.lock" }} |
There was a problem hiding this comment.
Would be nice making the key name related to the job name.
(contract_burner -> contract_token_tester)
contracts/token-tester/Cargo.toml
Outdated
| crate-type = ["cdylib", "rlib"] | ||
|
|
||
| [features] | ||
| default = ["cranelift"] |
There was a problem hiding this comment.
Any reason to use cranelift as default?
(I think only the singlepass is fully implemented currently)
There was a problem hiding this comment.
You're right. fixed!
* feat: enable circleci * fix: apply review
Closes: #2
Description
The purpose of this PR is to set up circle CI for newly added ext and contract, so I prepared implementation of minimum to see if the circle CI works properly.
Motivation and context
How has this been tested?
Checklist: