Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add ci tests for package derive #231

Merged
merged 1 commit into from
Aug 24, 2022
Merged

ci: add ci tests for package derive #231

merged 1 commit into from
Aug 24, 2022

Conversation

loloicci
Copy link
Contributor

Description

Closes #228

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Aug 23, 2022
da1suk8
da1suk8 reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@da1suk8 da1suk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks the same as #230 except for the version difference, but what is the reason for distinguishing it from #230 ?

Is this a PR to check the effect of the version difference?

@loloicci
Copy link
Contributor Author

It looks the same as #230 except for the version difference, but what is the reason for distinguishing it from #230 ?

This PR is for main branch and #230 is for dynamic_link branch. I think both branches need the same ci tests before merging one into another one, and I make 2 PRs.

@da1suk8
Copy link
Member

da1suk8 commented Aug 24, 2022

Sorry, I didn't check it properly. Thank you.

shiki-tak
shiki-tak approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit f36b7af into Finschia:main Aug 24, 2022
@loloicci loloicci deleted the ci-derive branch August 24, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@da1suk8 da1suk8 da1suk8 approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

Assignees

@loloicci loloicci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ci test for package derive
3 participants
@loloicci @da1suk8 @shiki-tak