Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify vm::testing::Contract #181

Merged
merged 4 commits into from
Apr 18, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Apr 5, 2022

Description

This PR simplifies vm::testing::Contract and makes it not take too much ownership of Backend.

This enables to specify the used querier and APIs in each generating instance from Contract. For example, using #180 's update_wasm after constructing a contract needs this PR.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

Copy link
Contributor

@brew0722 brew0722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, LGTM.
However, during the review, I was confused as to why this PR is need.
I think it would be good to explain in the this PR body that the purpose is to easily reuse the same db in the PR below.

https://github.com/line/cosmwasm-simulator/pull/21/files#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fcR373

@loloicci
Copy link
Contributor Author

I think it would be good to explain in the this PR body that the purpose is to easily reuse the same db in the PR below.

Thank you @brew0722. The point is not only reusing DB but making instances with specified querier and APIs. I updated the descryption.

@loloicci loloicci merged commit 9fb952b into Finschia:main Apr 18, 2022
@loloicci loloicci deleted the simplify-testing-contract branch April 18, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants