Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export vm::testing::contract::Contract #147

Merged
merged 2 commits into from
Dec 8, 2021
Merged

fix: export vm::testing::contract::Contract #147

merged 2 commits into from
Dec 8, 2021

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Dec 8, 2021 •
edited
Loading

Description

This is caused by omitted exports in #86.
Closes #146.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Dec 8, 2021
@shiki-tak
Copy link
Contributor

Do we need this lack?
https://github.com/line/cosmwasm/pull/86/files#diff-30b05c6d8f857968ac0763dc3babdc75d98687df697c3b0d1bfdeb9864d1d4acL22

brew0722
brew0722 approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@brew0722 brew0722 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 0.14.0 merge process, export testing::Contract for the simulator was omitted. This PR will be exposed as a pub so that we can use it again in the simulator. so, LGTM

@loloicci
Copy link
Contributor Author

loloicci commented Dec 8, 2021

@shiki-tak They are needed. fixed. Thank you!

@loloicci loloicci merged commit 63aabb5 into Finschia:main Dec 8, 2021
@loloicci loloicci deleted the export-contract branch December 8, 2021 08:24
loloicci added a commit to loloicci/line-cosmwasm that referenced this pull request Dec 22, 2021
@loloicci
chore: cargo fmt for Finschia#147
9c09778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@brew0722 brew0722 brew0722 approved these changes

@zemyblue zemyblue Awaiting requested review from zemyblue

Assignees

@loloicci loloicci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cosmwasm-vm::testing::contract::Contract is not exported
3 participants
@loloicci @shiki-tak @brew0722