Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

flexible upload support #1917

Closed
wants to merge 43 commits into from
Closed

flexible upload support #1917

wants to merge 43 commits into from

Conversation

rnicholus
Copy link
Member

@rnicholus rnicholus commented Sep 13, 2017 •
edited
Loading

rnicholus added 14 commits September 11, 2017 16:20
ports 3000/3001 clash with my local env, and possibly others
80dd701 
- moving to 4000/4001
Start of support for promissory onUploadChunk event
949a958 
- Manual tests w/ chunking and concurrent chunking look good.

TODO:
- handle resolve result
- handle failure
- unit tests
- docs uppdate
- typescript defs update
returned onUploadChunk promise con override method, params, headers, …
2b8e681 
…& url
always ensure test server are killed either on test start or stop
364c2a6
don't try to kill test server on CI before tests start
167ad40
forgot to start the test resources server on CI
d861764
promissory onUpload callback + handle async failure of onUpload/chunk
6753613
option to allow upload responses without { "success": true }
ef7b7bc
allow default params to be omitted from upload requests
a3d0968
1st alpha release with most of the changes obviously needed for flexi…
9a581fd 
…ble workflow
don't fail upload w/ non-JSON response when requireSuccessJson = false
2e827ce
5.16.0-alpha.1
f710d04
more flexible chunking.success request support
494be7c
5.16.0-alpha.2
2bf5820
@rnicholus
Copy link
Member Author

rnicholus commented Sep 15, 2017 •
edited
Loading

Progress here:

  • onUploadChunk can return a Promise that optionally overrides endpoint, params, headers, and method for the chunk upload.
  • onUpload can return a Promise.
  • New function type options for the chunking.success option: headers and params. Also jsonPayload boolean and method string. Finally, endpoint accepts a function value. All function options are passed the file ID.
  • New request.omitDefaultParams option. If set, Fine Uploader doesn't send any "qq" params w/ the upload request.
  • New request.requireSuccessJson option. If not set, upload endpoint does not need to return { "success": true } to indicate success.
  • More flexible resume support (allow custom keys/data)
  • allow per-file chunking.partSize
  • Unit tests to cover everything.
  • Documentation updates.
  • Document chunking.mandatory option.
  • Typescript def file updates. (cc: @SinghSukhdeep)
  • fine-uploader-wrappers updates to cover any new API features (i.e. more async support).

@rnicholus rnicholus mentioned this pull request Sep 18, 2017
Closed
@FineUploader FineUploader deleted a comment from webmaster-mms Sep 22, 2017
@rnicholus rnicholus mentioned this pull request Sep 27, 2017
Closed
rnicholus pushed a commit to FineUploader/fine-uploader-wrappers that referenced this pull request Sep 27, 2017
feat(callback-names): onUpload and onUploadChunk now accept promises
40b7cf8 
FineUploader/fine-uploader#1917
rnicholus added a commit to FineUploader/fine-uploader-wrappers that referenced this pull request Sep 28, 2017
@rnicholus
fix(callback-proxy): callback values not passed through to Fine Uploader
31df221 
fixes #5

Also:
feat(callback-names): onUpload and onUploadChunk now accept promises
re: FineUploader/fine-uploader#1917
This was referenced Oct 10, 2017
Closed
Closed
@singhjusraj
Copy link
Member

@rnicholus I can work on updating the TS def now? as your planned development is complete.

@rnicholus
Copy link
Member Author

@SinghSukhdeep sounds good. I don't have any of the docs updated yet, so if anything isn't clear, LMK. there are a lot of changes here...

@rnicholus
Copy link
Member Author

I believe I have now written sufficient unit tests for all changes/additions in this PR.

@rnicholus rnicholus added this to the 5.16.0 milestone Oct 16, 2017
@rnicholus rnicholus mentioned this pull request Oct 20, 2017
Closed
@singhjusraj
Copy link
Member

Would need the docs updated before I can start with TS update.
Lot seems to have changed and I can't seem to figure everything out by looking at all the changes.
Doc update would point me in straight direction.

@rnicholus
Copy link
Member Author

Docs are next on my list...

@rnicholus
Copy link
Member Author

API docs updated!

singhjusraj
singhjusraj reviewed Nov 1, 2017
View reviewed changes
docs/api/events.jmd Outdated
{{ api_event("upload", "onUpload", "Called just before an item begins uploading to the server.",
{{ api_event("upload", "onUpload",
"""
Called just before an item begins uploading to the server. In asynchronous work must be performed,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@singhjusraj
Copy link
Member

TypeScript Updated

@rnicholus
Copy link
Member Author

Thanks @SinghSukhdeep. Looks like everything is done here. Just need to let all of these changes cook on a project of mine before I release (along with a bit more manual testing). Would love to hear if others are having success with this branch.

This was referenced Nov 4, 2017
Closed
Closed
Closed
This was referenced Nov 6, 2017
Closed
Closed
@rnicholus rnicholus closed this Nov 8, 2017
@rnicholus rnicholus mentioned this pull request Nov 8, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@singhjusraj singhjusraj singhjusraj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rnicholus @singhjusraj