Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

chore(Makefile): remove duplicate line #1691

Merged
merged 2 commits into from
Dec 11, 2016
Merged

chore(Makefile): remove duplicate line #1691

merged 2 commits into from
Dec 11, 2016

Conversation

guzart
Copy link
Contributor

@guzart guzart commented Nov 20, 2016

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2016

CLA assistant check
All committers have signed the CLA.

@rnicholus
Copy link
Member

Nice catch. This means the qq.Identify module is defined twice in the built code. Even though this is a small module and size will only decrease a small amount, I think that merits a hotfix release. Thanks!

Going forward, changes should be initially based off of develop. This is why I have an issue template, which you deleted. But I do thank you again for your help here.

@rnicholus rnicholus changed the base branch from master to develop November 20, 2016 02:50
@rnicholus rnicholus added this to the 5.11.10 milestone Nov 20, 2016
@guzart
Copy link
Contributor Author

guzart commented Nov 20, 2016

Apologize for not following guidelines, I just saw that duplicate line while I was reading the code and went to submit a pull request using Github's UI. Will submit changes from develop next time 😸

@rnicholus
Copy link
Member

This is going to go out today (likely) as part of 5.11.10. Thanks for your help!

@rnicholus rnicholus merged commit 4b6809e into FineUploader:develop Dec 11, 2016
rnicholus added a commit that referenced this pull request Dec 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants