Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-903 Make library npm-compatible #88

Merged
merged 3 commits into from
Sep 3, 2021
Merged

CON-903 Make library npm-compatible #88

merged 3 commits into from
Sep 3, 2021

Conversation

chivchila
Copy link
Contributor

@chivchila chivchila commented Aug 26, 2021

This is very similar to PR https://github.com/Financial-Times/n-messaging-client/pull/360

Adding an option to install n-syndication lib through npm only. This is needed for the projects that no longer use bower

@chivchila chivchila changed the title Draft PR: Make library npm-compatible CON-903 Make library npm-compatible Aug 27, 2021
@chivchila chivchila marked this pull request as ready for review September 1, 2021 12:57
@chivchila chivchila requested a review from a team September 1, 2021 12:57
bower.json Show resolved Hide resolved
@chivchila chivchila force-pushed the make_npm_compatible branch 2 times, most recently from 6fdddaa to 72d6f3d Compare September 2, 2021 14:24
Copy link
Member

@joelcarr joelcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few comments, let me know what you think 👍

src/js/modal-download.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@joelcarr joelcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you @chivchila! 🎉

@chivchila chivchila merged commit 73d6b5d into main Sep 3, 2021
@chivchila chivchila deleted the make_npm_compatible branch September 3, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants