-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CON-903 Make library npm-compatible #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chivchila
changed the title
Draft PR: Make library npm-compatible
CON-903 Make library npm-compatible
Aug 27, 2021
chivchila
commented
Sep 1, 2021
chivchila
force-pushed
the
make_npm_compatible
branch
2 times, most recently
from
September 2, 2021 14:24
6fdddaa
to
72d6f3d
Compare
gyss
approved these changes
Sep 2, 2021
joelcarr
reviewed
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few comments, let me know what you think 👍
chivchila
force-pushed
the
make_npm_compatible
branch
from
September 3, 2021 09:29
72d6f3d
to
dfe3f0a
Compare
chivchila
force-pushed
the
make_npm_compatible
branch
from
September 3, 2021 09:35
dfe3f0a
to
41f4938
Compare
joelcarr
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Thank you @chivchila! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to PR https://github.com/Financial-Times/n-messaging-client/pull/360
Adding an option to install n-syndication lib through npm only. This is needed for the projects that no longer use bower