ACC-2147-chore: Bumping up some of the dev dependencies version #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nazehs
force-pushed
the
bumping-package-versions
branch
2 times, most recently
from
f183500 to
bf08043
Compare
Nazehs
changed the title
danieleruiz
requested changes
Jan 24, 2023
jest.config.js
Outdated
| @@ -1,5 +1,6 @@ | |||
| module.exports = { | |||
| moduleDirectories: ['node_modules'], | |||
| testEnvironment: 'jsdom', | |||
There was a problem hiding this comment.
Question: is this necesary? this add jsdom as default environment to all test, that means that all the test going to have all the dom properties, using more amount of ram and can broke the test in ci, you can specify the jsdom environment just in the particular test class that need it
There was a problem hiding this comment.
[Comment] tests are not passing if testEnvironment is not defined as jsdom and that is because i upgraded the version of jest to the latest version v29 which has a breaking change for that from v27.
Danieler
approved these changes
Jan 24, 2023
Nazehs
force-pushed
the
bumping-package-versions
branch
from
8eeaf64 to
eef6765
Compare
danieleruiz
approved these changes
Jan 24, 2023
jamesr101
approved these changes
Jan 27, 2023
Nazehs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bump up outdated version of autoprefixer which has a known bug parsing @supports selector() {} CSS Syntax.
that was resulting to builds to error when the latest version of Origami components are pulled in, preventing deploy.
This PR also bumped up other dev dependencies and add
npm testscript commandfix #121
Jira ticket