Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACC-1360 update bower components #103

Merged
merged 2 commits into from
Jan 26, 2022
Merged

ACC-1360 update bower components #103

merged 2 commits into from
Jan 26, 2022

Conversation

asugar13
Copy link
Contributor

Updating origami components to their latest bower available version: https://origami.ft.com/blog/2021/07/01/origami-on-npm-and-how-to-migrate/#last-bower-releases

JIRA

@asugar13 asugar13 requested a review from a team January 25, 2022 13:57
@@ -20,11 +20,11 @@
"dependencies": {
"n-ui-foundations": "^6.0.0",
"next-session-client": "^3.0.1",
"o-buttons": "^6.0.2",
"o-buttons": "^6.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why do you downgrade this patch?

"o-message": "^4.1.8",
"o-icons": "^6.3.0"
"o-message": "^4.0.0",
"o-icons": "^6.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why do you downgrade these minors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to keep it consistent. since the ^already patches to the most recent minor version.

@asugar13 asugar13 merged commit e6462fe into main Jan 26, 2022
@asugar13 asugar13 deleted the ACC11360 branch January 26, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants