This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Don't run npm update in Heroku postbuild task #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heroku-postbuild is a task that is typically called via a `heroku-postbuild` script in the project's `package.json`, which will be called during a Heroku build after the main build script has run. One command in the task is `npm update`. Since npm 8.3.2, this command will now automatically prune dev dependencies if running in a production Node environment (it's unclear if this was a conscious change.) This means that subsequent steps in the task fail as n-gage has been pruned prematurely. I don't think we really want to be running `npm update` after we've build the Heroku app anyway, especially now that we have lockfiles in most projects.
apaleslimghost
approved these changes
Apr 12, 2022
This was referenced Apr 12, 2022
Closed
Closed
This was referenced Apr 12, 2022
This was referenced Apr 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heroku-postbuildis a task that is typically called via aheroku-postbuildscript in the project'spackage.json, which will be called during a Heroku build after the main build script has run. One command in the task isnpm update. Since npm 8.3.2, this command will now automatically prune dev dependencies if running in a production Node environment (it's unclear if this was a conscious change.) This means that subsequent steps in the task fail as n-gage has been pruned prematurely.I don't think we really want to be running
npm updateafter we've build the Heroku app anyway, especially now that we have lockfiles in most projects.