Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

Commit

Permalink
Merge pull request #433 from Financial-Times/remove-coronavirus-econo…
Browse files Browse the repository at this point in the history
…mic-tracker-amp

Remove coronavirus economic tracker from AMP 🐿 v2.12.5
  • Loading branch information
joannaskao authored Mar 18, 2020
2 parents 2fb3546 + 616ded5 commit e6504e3
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions secret-squirrel.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ module.exports = {
files: {
allow: [
'makefile',
'scripts/dev-utils/certificate.cnf'
'scripts/dev-utils/certificate.cnf',
],
allowOverrides: []
allowOverrides: [],
},
strings: {
deny: [],
Expand All @@ -18,6 +18,7 @@ module.exports = {
'263615ca-d873-11e9-8f9b-77216ebe1f17', // server/controllers/amp-page.js:8
'f3bb0944-4437-11ea-abea-0c7a29cd66fe', // server/controllers/amp-page.js:9
'a26fbf7e-48f8-11ea-aeb3-955839e06441', // server/controllers/amp-page.js:10
'0c13755a-6867-11ea-800d-da70cff6e4d3', // server/controllers/amp-page.js:11
'b4284269-2951-3169-ab98-88c184da5e88', // test/amp-transform/blockquotes.js:39, test/utils/test-uuids.js:32
'56f6ad50-da52-11e5-a72f-1e7744c66818', // test/amp-transform/external-image.js:7|25
'0a5e1620-c0f5-11e5-846f-79b0e3d20eaf', // test/amp-transform/related-box.js:38|44
Expand Down Expand Up @@ -118,6 +119,6 @@ module.exports = {
'21b5893e-ba3a-32dc-bf31-271449002cc0', // test/utils/test-uuids.js:79
'f50909a8-95dd-3688-9b12-a67e1198e6d5', // test/utils/test-uuids.js:80
'079a37bc-db50-11e7-a039-c64b1c09b482', // test/utils/test-uuids.js:83
]
}
],
},
};
1 change: 1 addition & 0 deletions server/controllers/amp-page.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const articlesToSkip = [
'263615ca-d873-11e9-8f9b-77216ebe1f17', // UK 2019 general election poll tracker: contains dynamic image that shouldn't be cached
'f3bb0944-4437-11ea-abea-0c7a29cd66fe', // US 2019 democratic primaries delegate tracker: contains dynamic image that shouldn't be cached
'a26fbf7e-48f8-11ea-aeb3-955839e06441', // Coronavirus tracker map: contains dynamic image that shouldn't be cached
'0c13755a-6867-11ea-800d-da70cff6e4d3', // Coronavirus economic tracker page: contains dynamic image taht shouldn't be cached
];

module.exports = (req, res, next) => {
Expand Down

0 comments on commit e6504e3

Please sign in to comment.