Skip to content

Commit

Permalink
Merge pull request #408 from Financial-Times/drop-node-14
Browse files Browse the repository at this point in the history
Drop support for Node 14
  • Loading branch information
ivomurrell authored Apr 18, 2023
2 parents a06d74e + c7c7bfb commit 4a8d37a
Show file tree
Hide file tree
Showing 6 changed files with 76 additions and 40 deletions.
28 changes: 14 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,21 +187,21 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- test:
requires:
- build-v<< matrix.node-version >>
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- lint:
requires:
- build-v<< matrix.node-version >>
name: lint-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]

release-please:
when:
Expand Down Expand Up @@ -231,21 +231,21 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- test:
requires:
- build-v<< matrix.node-version >>
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- lint:
requires:
- build-v<< matrix.node-version >>
name: lint-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]

build-test-publish:
when:
Expand All @@ -260,7 +260,7 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- test:
filters:
<<: *filters_release_build
Expand All @@ -269,7 +269,7 @@ workflows:
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- lint:
filters:
<<: *filters_release_build
Expand All @@ -278,7 +278,7 @@ workflows:
name: lint-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- publish:
context: npm-publish-token
filters:
Expand All @@ -300,7 +300,7 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- test:
filters:
<<: *filters_prerelease_build
Expand All @@ -309,7 +309,7 @@ workflows:
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- lint:
filters:
<<: *filters_prerelease_build
Expand All @@ -318,7 +318,7 @@ workflows:
name: lint-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- prepublish:
context: npm-publish-token
filters:
Expand All @@ -342,15 +342,15 @@ workflows:
name: build-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]
- test:
requires:
- build-v<< matrix.node-version >>
context: next-nightly-build
name: test-v<< matrix.node-version >>
matrix:
parameters:
node-version: [ '16.14', '14.19' ]
node-version: [ '16.14' ]

# Prior to producing a development orb (which requires credentials) basic validation, linting, and even unit testing can be performed.
# This workflow will run on every commit
Expand Down
4 changes: 2 additions & 2 deletions core/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@dotcom-tool-kit/webpack": "^2.1.15",
"@jest/globals": "^27.4.6",
"@types/lodash": "^4.14.185",
"@types/node": "^12.20.24",
"@types/node": "^16.18.23",
"chai": "^4.3.4",
"globby": "^10.0.2",
"ts-node": "^8.10.2",
Expand All @@ -54,7 +54,7 @@
"zod-validation-error": "^0.3.0"
},
"engines": {
"node": ">=8.0.0"
"node": "16.x"
},
"files": [
"/bin",
Expand Down
2 changes: 1 addition & 1 deletion core/create/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"devDependencies": {
"@types/financial-times__package-json": "^1.9.0",
"@types/lodash": "^4.14.185",
"@types/node": "^12.20.24",
"@types/node": "^16.18.23",
"@types/node-fetch": "^2.6.2",
"@types/pacote": "^11.1.3",
"@types/prompts": "^2.0.14",
Expand Down
2 changes: 1 addition & 1 deletion lib/wait-for-ok/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"bugs": "https://github.com/financial-times/dotcom-tool-kit/issues",
"homepage": "https://github.com/financial-times/dotcom-tool-kit/tree/main/lib/wait-for-ok",
"devDependencies": {
"@types/node": "^12.20.24",
"@types/node": "^16.18.23",
"@types/node-fetch": "^2.5.10",
"winston": "^3.5.1"
},
Expand Down
76 changes: 56 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 4a8d37a

Please sign in to comment.