Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the -i, -o flags, and other improvements #6

Closed
wants to merge 2 commits into from
Closed

Add the -i, -o flags, and other improvements #6

wants to merge 2 commits into from

Conversation

The-King-of-Toasters
Copy link

  • Only check for invalid flag combinations once, outside the switch.
  • Pass os.Files for each function instead of using stdin/stderr by default.

The last comment replaces the use of fmt.Printf with file.WriteString. This may fix #2, but I don't have a Windows system on hand to check.

Modify all functions to take a file instead of using os.Stdin/Stderr by
default
@FiloSottile
Copy link
Owner

Hey, thanks for contributing, but as I mentioned in the README and in #3 (comment), I am actively developing this and already conflicted over these changes :(

Can you help me understand why would replacing fmt.Printf help? I could see Println adding CRLF, but I'd be surprised by Printf doing that.

@The-King-of-Toasters
Copy link
Author

Hey, thanks for contributing, but as I mentioned in the README and in #3 (comment), I am actively developing this and already conflicted over these changes :(

That's fine. I thought by adding a couple small changes that they would get through. I'm happy to step aside on this :).

Can you help me understand why would replacing fmt.Printf help? I could see Println adding CRLF, but I'd be surprised by Printf doing that.

I though that writing direct to a file would solve #2, but that seems to be a auto-conversion issue with PowerShell. It was also a way to get rid of fmt, as it was only used for those three lines.

Other than the Printf issue, is there any other change that's conflicting?

@The-King-of-Toasters
Copy link
Author

Actually, I can see a lot wrong with my work so far. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

age fails to decrypt files generated in Windows PowerShell
2 participants