Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase decryption recipient limit from 20 to 1000 #140

Closed
wants to merge 1 commit into from

Conversation

ryantm
Copy link

@ryantm ryantm commented Sep 4, 2020

closes #139

I tested decrypting my file with 69 recipients and it worked.

@ryantm
Copy link
Author

ryantm commented Sep 4, 2020

CI build failure appears to be unrelated.

# filippo.io/age/internal/bech32_test
173internal/bech32/bech32_test.go:46:12: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

@johanfleury
Copy link

Why even keep a limit here? There’s not comments in the code and I can’t find a replay of the Twitch stream mentioned in the commit message.

I think, if we keep this limit (either increasing it or keeping it as is), we should document it somehow.

@FiloSottile could you explain the reason behind this check?

@ryantm
Copy link
Author

ryantm commented Sep 16, 2020

The limit does not exist in the specification or the rage implementation.

@str4d
Copy link

str4d commented Dec 31, 2020

See #139 for continued discussion.

@ryantm ryantm closed this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider 20 recipients limit
3 participants