Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BaseMap::$instance BC issue #85

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix BaseMap::$instance BC issue #85

merged 1 commit into from
Oct 20, 2024

Conversation

mondrake
Copy link
Contributor

Fixes #84

@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (6a77084) to head (5032099).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage     96.36%   96.36%           
  Complexity      222      222           
=========================================
  Files             9        9           
  Lines           523      523           
=========================================
  Hits            504      504           
  Misses           19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mondrake mondrake merged commit c8c686c into FileEye:master Oct 20, 2024
8 checks passed
@mondrake mondrake deleted the dev-bc1020 branch October 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileEye\MimeMap\Map\BaseMap::$instance typing breaks BC
1 participant
@mondrake