Include the desktop fix, for incorrect model appearance, in android (#6) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbalajee
added a commit
that referenced
this pull request
Jul 29, 2024
… FAssetLoader which skips loading the buffer in AssetLoaderExtended#createPrimitive leading to null pointer crash moving init to member initialization list in constructor Revert "Include the desktop fix, for incorrect model appearance, in android (#6) (#12)" This reverts commit 4257269. Revert "utility::loadCgltfBuffers is done once instead of doing for each primitive (google#7969)" This reverts commit 3728f06. Revert "Adding parent name as default if node has no name (#10)" This reverts commit 7558f89
mbalajee
added a commit
that referenced
this pull request
Aug 26, 2024
mbalajee
added a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the normals aren't exported in the GLB model then Filament wasn't generating them properly when the vertices in the model are shared by triangles. This PR fixes that issue but is available only for desktop for this reason (tbh honest i don't quite understand that comment - i din't have to make any changes in ResourceLoader) so I just lifted the restriction on Android platform which seem to work
Some background for this issue,
google#7851
google#6358