Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially implements #431 and should be able to detect #265 and #442 (if the code segments are sufficiently large).
What is working?
StructuralHashCodeVisitor
to have a minimum amount of hashCode collisions (at the cost of not detecting some duplicate codes). For example, by hashing all named elements, the time can be further reduced to only 12ms, but that is not feasible, because it should be able to detect duplicate code segments, where only the name of a variable is different.What is missing?
StructuralEquality
works well. (by comparing it to the slower version in debug mode)if (paramIsTrue) { doA(); } else { doB(); }
)