Add Redis population support class #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FengPan-Frank
force-pushed
the
fenpan_redis
branch
4 times, most recently
from
7d65ace to
675efa0
Compare
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
| std::vector<std::pair<std::string, std::string> > fieldValues; | ||
| std::string nei; | ||
| nei = peer.peer_addr; | ||
| fieldValues.push_back(std::make_pair("peer_addr", nei)); |
There was a problem hiding this comment.
Will update this at last moment to avoid possible namespace overlap.
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
Server/src/RedisManager.cpp
Outdated
| /*********************************************************************//** | ||
| * Get singleton instance for class | ||
| ***********************************************************************/ | ||
| RedisManager& RedisManager::getInstance() { |
There was a problem hiding this comment.
no, just want to keep it simple without passing reference to multiple places, as redis holds dedicated session meanwhile.
qiluo-msft
reviewed
Mar 26, 2024
qiluo-msft
reviewed
Mar 26, 2024
| @@ -134,7 +134,8 @@ bool BMPReader::ReadIncomingMsg(BMPListener::ClientInfo *client) { | |||
| peer_info_key = p_entry.peer_addr; | |||
| peer_info_key += p_entry.peer_rd; | |||
|
|
|||
|
|
|||
| if (bmp_type != parseBMP::TYPE_PEER_UP) | |||
There was a problem hiding this comment.
sql path has this, I removed it from master when bring up pipeline to avoid resolving kafka dependency issue. refer https://github.com/FengPan-Frank/sonic-bmp/pull/1/files#diff-3603581512f176e859579625d032262b922c76fa5fc3a44178d6e66ad1a176ea as initial commit.
FengPan-Frank
force-pushed
the
fenpan_redis
branch
2 times, most recently
from
139fc19 to
1ddd701
Compare
|
sonic-net/sonic-bmp#4, use public repo PR instead. |
FengPan-Frank
force-pushed
the
fenpan_redis
branch
from
1ddd701 to
a2d8adb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Redis population support class