-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifying view tools, histogram and overview, to some extend and persisting their settings within and between sessions #6
Conversation
…ols, started adapting histogram view controller;
…ties are used and updated correctly;
…er; added some notes in HistogramViewController;
…ontroller, added central parseSMILES method in ChemUtil;
…sion and between sessions, calls to them are now managed through view tools manager;
About the merge conflicts: ListUtil has been renamed to CollectionUtil and extended on master but I have made only small changes here in that class; so that should be easy to amend. The only conflicting changes in HistogramViewController are also referring to this: The usage of ListUtil has -of course- been changed to CollectionUtil on master, but that's it. So, also easy to fix. |
Fixed the merge conflicts 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but please answer questions
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/controller/ViewToolsManager.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/model/data/MoleculeDataModel.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am finished so far. All the settings are there in the histogram view. All the settings work as expected, I haven't found any errors.
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Outdated
Show resolved
Hide resolved
Dear all, after reviewing the code related to the OverviewView, I am very pleased with the changes you have done, @JonasSchaub. The ViewToolsManager is a really nice addition to the code. One thing I noticed: |
@SamuelBehr if the user then enlarges the window, the structures appear at some point, right? If yes, I would declare this as a "won't fix" because no window size in MORTAR is cached or persisted at this point. |
@JonasSchaub Yes, exactly. The structures are visible again at the latest when the privious window size is reached. Since this might be "a barrel we should not open" and since it is not really a problem anyways, I am fine with declaring it as "won't fix". |
@SamuelBehr, more like a "box" of a specific character from Greek mythology.
Great, then please approve the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested the code. See my comments above.
Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please answer question
src/main/java/de/unijena/cheminf/mortar/controller/HistogramViewController.java
Outdated
Show resolved
Hide resolved
correct casting
added try catch block
Histogram unification
@FelixBaensch and @B-s123 please (re-)confirm that this can be merged now. |
approved |
Dear @FelixBaensch , @BetuelSevindik , and @SamuelBehr ,
I have unified the histogram and overview "view tools" now to some extend. They are managed now through the new "ViewToolsManager" class which is used to open the views and -most importantly- takes care of their settings, so that they are persisted within a MORTAR session and also between MORTAR sessions.
Please, review and test as much as you can!
Also, some of the open TODO comments I just won't fix now, so that I stop blocking the repository for now.