Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying view tools, histogram and overview, to some extend and persisting their settings within and between sessions #6

Merged
merged 21 commits into from
Jun 26, 2023

Conversation

JonasSchaub
Copy link
Collaborator

Dear @FelixBaensch , @BetuelSevindik , and @SamuelBehr ,

I have unified the histogram and overview "view tools" now to some extend. They are managed now through the new "ViewToolsManager" class which is used to open the views and -most importantly- takes care of their settings, so that they are persisted within a MORTAR session and also between MORTAR sessions.

Please, review and test as much as you can!

Also, some of the open TODO comments I just won't fix now, so that I stop blocking the repository for now.

@JonasSchaub JonasSchaub added the enhancement New feature or request label Jun 8, 2023
@JonasSchaub
Copy link
Collaborator Author

About the merge conflicts: ListUtil has been renamed to CollectionUtil and extended on master but I have made only small changes here in that class; so that should be easy to amend. The only conflicting changes in HistogramViewController are also referring to this: The usage of ListUtil has -of course- been changed to CollectionUtil on master, but that's it. So, also easy to fix.

@JonasSchaub
Copy link
Collaborator Author

Fixed the merge conflicts 👍

Copy link
Owner

@FelixBaensch FelixBaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please answer questions

Copy link
Collaborator

@B-s123 B-s123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am finished so far. All the settings are there in the histogram view. All the settings work as expected, I haven't found any errors.

@SamuelBehr
Copy link
Collaborator

Dear all,

after reviewing the code related to the OverviewView, I am very pleased with the changes you have done, @JonasSchaub. The ViewToolsManager is a really nice addition to the code.
Also I do not find the functionalities of the overview view to have changed in any kind of way due to your changes - except from the grid configuration being persisted, which seems to be working fine.

One thing I noticed:
Because the configuration of the grid of the overview view is now persisted - but not the size of the window, it is now possible that the overview opens and the persisted number of structures cannot be displayed. However, since I assume that a user who has set such a high number of rows and columns in a previous use of the overview view will adjust the size of the overview window afterwards anyway, this should not be a problem.
This situation is handled as it can be seen in the attached picture.
Screenshot 2023-06-19 151259

@JonasSchaub
Copy link
Collaborator Author

@SamuelBehr if the user then enlarges the window, the structures appear at some point, right? If yes, I would declare this as a "won't fix" because no window size in MORTAR is cached or persisted at this point.

@SamuelBehr
Copy link
Collaborator

@JonasSchaub Yes, exactly. The structures are visible again at the latest when the privious window size is reached.

Since this might be "a barrel we should not open" and since it is not really a problem anyways, I am fine with declaring it as "won't fix".

@JonasSchaub
Copy link
Collaborator Author

@SamuelBehr, more like a "box" of a specific character from Greek mythology.

I am fine with declaring it as "won't fix".

Great, then please approve the pull request.

Copy link
Collaborator

@SamuelBehr SamuelBehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested the code. See my comments above.

Approved!

@JonasSchaub JonasSchaub removed the request for review from BetuelSevindik June 19, 2023 14:42
Copy link
Owner

@FelixBaensch FelixBaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please answer question

@JonasSchaub
Copy link
Collaborator Author

@FelixBaensch and @B-s123 please (re-)confirm that this can be merged now.

@B-s123
Copy link
Collaborator

B-s123 commented Jun 23, 2023

approved

@JonasSchaub JonasSchaub merged commit 53834f1 into master Jun 26, 2023
@JonasSchaub JonasSchaub deleted the tools_unification branch January 25, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants