-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of HashMap initialisations #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d on the number of elements to be stored and load factor; implemented its usage in all places in the MORTAR-own classes where new HashMaps are instantiated;
…ed basic definitions constant for default hash collection load factor;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me, just a few too many magic numbers for my taste
src/main/java/de/unijena/cheminf/mortar/model/util/CollectionUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/model/fragmentation/FragmentationService.java
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/model/fragmentation/FragmentationService.java
Show resolved
Hide resolved
...ijena/cheminf/mortar/model/fragmentation/algorithm/ErtlFunctionalGroupsFinderFragmenter.java
Show resolved
Hide resolved
...ava/de/unijena/cheminf/mortar/model/fragmentation/algorithm/ScaffoldGeneratorFragmenter.java
Show resolved
Hide resolved
...a/de/unijena/cheminf/mortar/model/fragmentation/algorithm/SugarRemovalUtilityFragmenter.java
Outdated
Show resolved
Hide resolved
src/main/java/de/unijena/cheminf/mortar/model/settings/SettingsContainer.java
Show resolved
Hide resolved
…d, declared magic numbers in local variables;
FelixBaensch
approved these changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented routine to calculate a suitable initial HashMap size based on the number of elements to be stored and load factor; implemented its usage in all places in the MORTAR-own classes where new HashMaps are instantiated;