Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of HashMap initialisations #5

Merged
merged 4 commits into from
May 2, 2023
Merged

Conversation

JonasSchaub
Copy link
Collaborator

Implemented routine to calculate a suitable initial HashMap size based on the number of elements to be stored and load factor; implemented its usage in all places in the MORTAR-own classes where new HashMaps are instantiated;

…d on the number of elements to be stored and load factor; implemented its usage in all places in the MORTAR-own classes where new HashMaps are instantiated;
…ed basic definitions constant for default hash collection load factor;
Copy link
Owner

@FelixBaensch FelixBaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, just a few too many magic numbers for my taste

…d, declared magic numbers in local variables;
Copy link
Owner

@FelixBaensch FelixBaensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@FelixBaensch FelixBaensch merged commit 4252ec5 into master May 2, 2023
@FelixBaensch FelixBaensch deleted the HashMap-initialisations branch May 2, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants