Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFGF artifact integration and dependency updates #25

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

JonasSchaub
Copy link
Collaborator

Replaced EFGF source files with EFGF maven artifact dependency; this required updating to Java v21; this required updating Gradle to v8.5; also updated CDK to v2.9, javaFx to 21.0.1, and spotless to v6.23.3; Java update made some minor code changes necessary because javadoc compilation threw warnings about missing default constructors and doubling comments on properties; also removed test resources of Scaffold Generator tests;

…required updating to Java v21; this required updating Gradle to v8.5; also updated CDK to v2.9, javaFx to 21.0.1, and spotless to v6.23.3; Java update made some minor code changes necessary because javadoc compilation threw warnings about missing default constructors and doubling comments on properties; also removed test resources of Scaffold Generator tests;
@JonasSchaub JonasSchaub self-assigned this Dec 20, 2023
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JonasSchaub JonasSchaub merged commit 97f5afa into master Dec 20, 2023
3 checks passed
@JonasSchaub JonasSchaub deleted the efgf-artifact-integration branch December 20, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants