Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameter #52

Closed
JonasSchaub opened this issue Mar 6, 2024 · 5 comments
Closed

Unused parameter #52

JonasSchaub opened this issue Mar 6, 2024 · 5 comments
Assignees

Comments

@JonasSchaub
Copy link
Collaborator

public ItemizationDataTableView(int anItemAmount, String aFragmentationName){

@FelixBaensch , the first parameter "anItemAmount" seems to be unused. Can I safely remove it?

@FelixBaensch
Copy link
Owner

If you customize the call as well

@JonasSchaub
Copy link
Collaborator Author

If you customize the call as well

... of course! But all in all, this is an artifact and the maximum fragment column number for the items tab is now determined in a different way, do I see this correctly?

@FelixBaensch
Copy link
Owner

Yes

int tmpItemAmount = GuiUtil.getLargestNumberOfFragmentsForGivenMoleculeListAndFragmentationName(this.itemsList.subList(fromIndex, toIndex), aFragmentationName);

@JonasSchaub
Copy link
Collaborator Author

Ah, thank you, didn't see that! I'll remove this param then 👍

@JonasSchaub
Copy link
Collaborator Author

Resolved by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants