fix the issue exsiting claim doesn't work for nodemanger #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Jing <jingch@vmware.com>
Closed
owlet42
approved these changes
Oct 20, 2022
asdfsx
pushed a commit
to asdfsx/KubeFATE
that referenced
this pull request
Oct 21, 2022
…#777) Signed-off-by: Chen Jing <jingch@vmware.com> Signed-off-by: Chen Jing <jingch@vmware.com> Signed-off-by: Sun Xia <asdfsx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Jing jingch@vmware.com
Description
Cannot set existing claim for nodemanager.
Although there is a problem for 2 replicas sharing one pv for a statefulsets, e.g., the 2 pods must be scheduled to one node, the existingClaim still should be a valid configuration when we set only one replica for node manager.
I will forget to package the helm chart of FUM