Skip to content

Commit

Permalink
fix parameter type check
Browse files Browse the repository at this point in the history
Signed-off-by: weiwee <wbwmat@gmail.com>
  • Loading branch information
sagewe committed Jul 21, 2023
1 parent 01974f7 commit d703012
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion python/fate/components/core/component_desc/_parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ def merge(self, p: "ParameterDescribe"):
raise ComponentParameterDuplicateError(
f"parameter {p.name} declare multiple times with different optional: `{self.optional}` vs `{p.optional}`"
)
if str(self.type) != str(p.type) or self.type.__dict__ != p.type.__dict__:
# if str(self.type) != str(p.type) or self.type.__dict__ != p.type.__dict__:
if str(self.type) != str(p.type):
raise ComponentParameterDuplicateError(
f"parameter {p.name} declare multiple times with different type: `{self.type}({self.type.__dict__})` vs `{self.type}({self.type.__dict__})`"
)
Expand Down

0 comments on commit d703012

Please sign in to comment.