Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Mr Bean from materializing types under java.* package #132

Closed
cowtowncoder opened this issue Apr 24, 2021 · 1 comment
Closed

Prevent Mr Bean from materializing types under java.* package #132

cowtowncoder opened this issue Apr 24, 2021 · 1 comment
Milestone

Comments

@cowtowncoder
Copy link
Member

(note: offshoot of FasterXML/jackson-modules-java8#215)

Looks like Mr Bean's AbstractTypeMaterializer method _suitableType() has a list of about dozen classes NOT to generate implementation for -- all under java.lang, java.util or java.io.
But it seems better to simply block everything under java.*, at this point; if further configurability needed we can add pluggable handler or something. For now, users can sub-class AbstractTypeMaterializer.

@cowtowncoder cowtowncoder added this to the 2.13.0 milestone Apr 24, 2021
@cowtowncoder
Copy link
Member Author

Ok, so:

  • 2.12(.4): prevents java.util.TimeZone materialization (the original case) but makes no other changes
  • 2.13(.0): by default blocks all java.* types (we'll see if there are counter examples we should materialize)

cowtowncoder added a commit that referenced this issue Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant