Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of union types at root level (fixes #168) #176

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Fix serialization of union types at root level (fixes #168) #176

merged 2 commits into from
Aug 15, 2019

Conversation

marcospassos
Copy link
Contributor

@marcospassos marcospassos commented Aug 6, 2019

Rebased for inclusion in 2.10. Fixes #168.

@marcospassos
Copy link
Contributor Author

@cowtowncoder could you include this fix in 2.10? We've been using it since then and no issues found so far.

@cowtowncoder
Copy link
Member

@marcospassos Apologies for slow follow-up: this (and couple of other) Avro issues are on my biggish todo list (https://github.com/FasterXML/jackson-future-ideas/wiki/Jackson-Work-in-Progress) but have been struggling with a few other issues.

But, I'll have a look at this (wrt #168) and #173 (for #175).

One last thing: have I yet asked for (and received) CLA? If not, it's at:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(or, if you prefer, there's corporate-CLA too although most contributions are with individual)
and the common way is to print it, fill, sign & scan, email to info at fasterxml dot com.
When I get it I can merge all contributions for any projects, it's just first-time thing we need.

Looking forward to merging these PRs!

@cowtowncoder
Copy link
Member

I didn't see anything odd so I think it's good to go.

One suggestion: if there are old methods left in for backwards compatibility, but that may eventually be removed (in 3.0), it makes sense to add @Deprecated (I am not sure if that is the case for factory methods that did not take currValue). I can easily drop those from 3.0 after merging.

@marcospassos
Copy link
Contributor Author

@cowtowncoder I just sent you the CLA.

One suggestion: if there are old methods left in for backwards compatibility, but that may eventually be removed (in 3.0), it makes sense to add @deprecated (I am not sure if that is the case for factory methods that did not take currValue). I can easily drop those from 3.0 after merging.

I don't think it's the case here.

@cowtowncoder cowtowncoder merged commit f5673da into FasterXML:2.10 Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants