jackson-bom manages the version of junit:junit

[wilkinsona]

I've just noticed that jackson-bom manages the version of junit:junit, inheriting it from jackson-parent. Ideally, Jackson's bom would only manage Jackson's own modules. This is currently causing a problem with JUnit 5.8 where there are some conflicting version requirements when building with Gradle:

Could not resolve all files for configuration ':spring-boot-tests:spring-boot-smoke-tests:spring-boot-smoke-test-junit-vintage:testCompileClasspath'.
> Could not resolve junit:junit:4.13.2.
  Required by:
      project :spring-boot-tests:spring-boot-smoke-tests:spring-boot-smoke-test-junit-vintage > project :spring-boot-project:spring-boot-parent > project :spring-boot-project:spring-boot-dependencies
  > Cannot find a version of 'junit:junit' that satisfies the version constraints:
       Dependency path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.junit.vintage:junit-vintage-engine:5.8.0' --> 'junit:junit:{strictly 4.13.2}'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'com.fasterxml.jackson:jackson-bom:2.12.5' --> 'junit:junit:4.13.1'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'junit:junit:4.13.2'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'com.fasterxml.jackson:jackson-bom:2.12.5' --> 'junit:junit:4.13.1'
> Could not resolve junit:junit:4.13.1.
  Required by:
      project :spring-boot-tests:spring-boot-smoke-tests:spring-boot-smoke-test-junit-vintage > project :spring-boot-project:spring-boot-parent > project :spring-boot-project:spring-boot-dependencies > com.fasterxml.jackson:jackson-bom:2.12.5
  > Cannot find a version of 'junit:junit' that satisfies the version constraints:
       Dependency path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.junit.vintage:junit-vintage-engine:5.8.0' --> 'junit:junit:{strictly 4.13.2}'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'com.fasterxml.jackson:jackson-bom:2.12.5' --> 'junit:junit:4.13.1'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'junit:junit:4.13.2'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'com.fasterxml.jackson:jackson-bom:2.12.5' --> 'junit:junit:4.13.1'
> Could not resolve junit:junit:{strictly 4.13.2}.
  Required by:
      project :spring-boot-tests:spring-boot-smoke-tests:spring-boot-smoke-test-junit-vintage > org.junit.vintage:junit-vintage-engine:5.8.0
  > Cannot find a version of 'junit:junit' that satisfies the version constraints:
       Dependency path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.junit.vintage:junit-vintage-engine:5.8.0' --> 'junit:junit:{strictly 4.13.2}'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'com.fasterxml.jackson:jackson-bom:2.12.5' --> 'junit:junit:4.13.1'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'junit:junit:4.13.2'
       Constraint path 'org.springframework.boot:spring-boot-smoke-test-junit-vintage:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-parent:2.6.0-SNAPSHOT' --> 'org.springframework.boot:spring-boot-dependencies:2.6.0-SNAPSHOT' --> 'com.fasterxml.jackson:jackson-bom:2.12.5' --> 'junit:junit:4.13.1'

[cowtowncoder]

Hmmh. Ok, yes, I can see how that could be problematic.

I'll try to refactor this so that managed dependency is promoted up to jackson-base (which has jackson-bom as parent), hopefully without causing issues on Jackson side. This for 2.13.0-SNAPSHOT, cannot do much about earlier versions at this point unfortunately.

[cowtowncoder]

Restructured (was already moved in master for 3.0), published jackson-parent 2.13-SNAPSHOT, jackson-bom/jackson-base 2.13.0-SNAPSHOT. Also jackson-annotations 2.13.0-SNAPSHOT as that is the only direct dep of jackson-parent for now.

@wilkinsona not sure if it is easy for you to verify, but latest 2.13.0-SNAPSHOTs for Jackson should now have the new managed deps wrt junit.

[wilkinsona]

Thanks very much, @cowtowncoder. I should be able to give it a try. What's Jackson's snapshots repository?

[cowtowncoder]

Sonatype OSS repo (the usual).

[wilkinsona]

Thank you. I can confirm that the changes in 2.13.0-SNAPSHOT fix the problem.

[jmax01]

Huh I thought this was fixed in FasterXML/jackson-parent#6 but I guess that was just the scope change.