Add requireTypeIdForSubtypes property for JsonTypeInfo.Value in Jackson 3.0
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
May 16, 2023
Comment on lines
216
to
219
| ======= | ||
| * | ||
| * @since 2.3 but databind <b>only since 2.5</b>. | ||
| >>>>>>> 2.16 | ||
| >>>>>>> 2.16 |
There was a problem hiding this comment.
Added a whitespace just to highlight this. I couldn't decide whether to remove @since... part or keep 😅
There was a problem hiding this comment.
Hmmh. My mistake, shouldn't have left these around. For 3.0 all "@SInCE 2.x" notes to be removed (assumption being that anything in 3.0 or earlier does not need it).... although now wondering if same should apply to annotations package or not.
But for now, yeah let's remove all @sinces (except maybe in some places can add @since 3.0 for something introduced only in 3.x.
|
Ok after merging the other PR, need to resolve conflict here. |
…rty-for-JsonTypeInfo.Value-in-3.0
cowtowncoder
approved these changes
May 16, 2023
JooHyukKim
deleted the
226-Add-require-type-id-for-subtypes-property-for-JsonTypeInfo.Value-in-3.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #226